Looking for feedback on new test runner #995
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjorsdonkers
reviewed
Sep 1, 2025
Follows up on #994 and replaces the jsRunner with a new page.navigation-based test runner. Currently only implemented for the Window tests, looking for feedback and converting every existing test will take time - so for a while, newRunner (to be renamed) will sit side-by-side with jsRunner. In addition to the benefits outlined in 994, largely around code simplicity and putting more of the actual code under tests, I think our WebAPI tests particularly benefit from: 1 - No need to recompile when modifying the html tests 2 - Much better assertions, e.g. you can assert that something is actually an array, not just a string representation of an array 3 - Ability to test some edge cases (e.g. dynamic script loading) I've put some effort into testing.js to make sure that, if the encapsulating zig test passes, it's because it actually passed, not because it didn't run. For the time being, console tests are removed. I think it's more useful to have access to the console within tests, than it is to test the console (which is just a wrapper around log, which is both tested and heavily used).
karlseguin
force-pushed
the
improved_test_runner
branch
from
81e9eff to
8a9cbaf
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up on #994 and replaces
the jsRunner with a new page.navigation-based test runner.
Currently only implemented for the Window tests, looking for feedback and
converting every existing test will take time - so for a while, newRunner (to be
renamed) will sit side-by-side with jsRunner.
In addition to the benefits outlined in 994, largely around code simplicity and
putting more of the actual code under tests, I think our WebAPI tests
particularly benefit from:
1 - No need to recompile when modifying the html tests
2 - Much better assertions, e.g. you can assert that something is actually an
array, not just a string representation of an array
3 - Ability to test some edge cases (e.g. dynamic script loading)
I've put some effort into testing.js to make sure that, if the encapsulating
zig test passes, it's because it actually passed, not because it didn't run.
For the time being, console tests are removed. I think it's more useful to have
access to the console within tests, than it is to test the console (which is
just a wrapper around log, which is both tested and heavily used).