DEVOPS-2754-changed-encryption-key-logic-to-not-fail-when-key-does-not-exist #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yption key won't be provided as part of external secret use case
yitzhaktal
commented
May 14, 2025
| secret: | ||
| secretName: {{ include "secrets.backend.name" . }} | ||
| optional: false | ||
| optional: {{ not .Values.general.deploy_secrets.enabled }} |
Contributor
Author
There was a problem hiding this comment.
If deploy_secrets = true ; chart is creating the encryption-key-0 by default, so backend pod will never fail, so optional will be false
if deploy_secrets = false; the customer creates the secret, and since optional will be true, it means weather or not he provides the encryption-key-0, we won't fail the mounting with
│ Warning FailedMount 26s (x7 over 58s) kubelet MountVolume.SetUp failed for volume "encryption-keys" : references non-existent secret key: encryption-key-0 │
imeliran
approved these changes
May 14, 2025
yitzhaktal
deleted the
DEVOPS-2754-changed-encryption-key-logic-to-not-fail-when-key-does-not-exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.