Skip to content

DEVOPS-2754-changed-encryption-key-logic-to-not-fail-when-key-does-not-exist #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 14, 2025
Merged

DEVOPS-2754-changed-encryption-key-logic-to-not-fail-when-key-does-not-exist #64

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion chart/templates/backend-deployment.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ spec:
- name: encryption-keys
secret:
secretName: {{ include "secrets.backend.name" . }}
optional: false
optional: {{ not .Values.general.deploy_secrets.enabled }}
Copy link
Contributor Author

@yitzhaktal yitzhaktal May 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If deploy_secrets = true ; chart is creating the encryption-key-0 by default, so backend pod will never fail, so optional will be false
if deploy_secrets = false; the customer creates the secret, and since optional will be true, it means weather or not he provides the encryption-key-0, we won't fail the mounting with
│ Warning FailedMount 26s (x7 over 58s) kubelet MountVolume.SetUp failed for volume "encryption-keys" : references non-existent secret key: encryption-key-0 │

items:
# Only select items that start with encryption-key-
{{- include "encryption.key.items" . | nindent 18 }}
Expand Down