Skip to content

feat: updating stainless.yml to remove base external account#211

Open
pengying wants to merge 1 commit intomainfrom
02-18-feat_updating_stainless.yml_to_remove_base_external_account
Open

feat: updating stainless.yml to remove base external account#211
pengying wants to merge 1 commit intomainfrom
02-18-feat_updating_stainless.yml_to_remove_base_external_account

Conversation

@pengying
Copy link
Contributor

@pengying pengying commented Feb 19, 2026

TL;DR

Remove BaseExternalAccountInfo allOf reference from ExternalAccountInfo schemas to fix type conflicts.

What changed?

Added a new transformation in the Stainless configuration to remove the $ref key from the allOf[0] property in multiple ExternalAccountInfo schemas. This affects 16 different account types including UsAccount, ClabeAccount, PixAccount, IbanAccount, and various wallet types.

How to test?

  1. Verify that the OpenAPI schema generation works correctly
  2. Ensure that the ExternalAccountInfo schemas no longer have conflicting types when merged with the base schema
  3. Confirm that client code generation works as expected with the updated schema

Why make this change?

The BaseExternalAccountInfo allOf references were causing type conflicts when the allOf operation merged them with the base schema. This change prevents these conflicts by removing the problematic references, resulting in more consistent and accurate type definitions.

Copy link
Contributor Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@pengying pengying marked this pull request as ready for review February 19, 2026 05:39
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 19, 2026

Greptile Summary

This PR adds a new OpenAPI schema transformation to the Stainless configuration that removes BaseExternalAccountInfo allOf references from 16 different ExternalAccountInfo schema variants (US accounts, IBAN, PIX, various crypto wallets, etc.). This follows the same pattern as existing transformations in the file that remove conflicting type definitions from allOf merges. The change is consistent with the established approach for handling type conflicts in the schema generation pipeline.

Confidence Score: 5/5

  • Safe to merge - follows established pattern for schema transformation
  • Configuration change follows the exact same pattern as 5 existing transformations in the file. The transformation removes problematic $ref keys to prevent type conflicts during allOf merging, which is a well-understood issue in OpenAPI schema composition. The change is declarative and low-risk.
  • No files require special attention

Important Files Changed

Filename Overview
.stainless/stainless.yml Adds transformation to remove $ref from allOf[0] in 16 ExternalAccountInfo schemas to fix type conflicts during schema merging

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[OpenAPI Schema] --> B{Stainless Transformations}
    B --> C[Remove customerType from fields]
    B --> D[Remove accountType from base schemas]
    B --> E[Remove sourceType from variants]
    B --> F[Remove destinationType from variants]
    B --> G[NEW: Remove BaseExternalAccountInfo $ref]
    G --> H[UsAccountExternalAccountInfo]
    G --> I[IbanAccountExternalAccountInfo]
    G --> J[PixAccountExternalAccountInfo]
    G --> K[Crypto Wallet Schemas]
    G --> L[12 other account types]
    H --> M[Client Code Generation]
    I --> M
    J --> M
    K --> M
    L --> M
    M --> N[Type-safe SDKs without conflicts]
Loading

Last reviewed commit: 8e33df3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

Comments