chore: sync Kotlin sample with paymentRail schema change#280
Open
claude[bot] wants to merge 1 commit intomainfrom
Open
chore: sync Kotlin sample with paymentRail schema change#280claude[bot] wants to merge 1 commit intomainfrom
claude[bot] wants to merge 1 commit intomainfrom
Conversation
Add support for optional paymentRail field in quote account destinations, aligning with the schema change in commit 309c629. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Greptile SummaryThis PR syncs the Kotlin sample app with the schema change from #279 that added an optional
Confidence Score: 5/5
|
| Filename | Overview |
|---|---|
| samples/kotlin/src/main/kotlin/com/grid/sample/routes/Quotes.kt | Adds optional paymentRail passthrough in buildQuoteDestination() using the established .apply { … ?.let { … } } builder pattern; no issues found. |
Sequence Diagram
sequenceDiagram
participant Client
participant KtorRoute as Ktor /api/quotes
participant buildQuoteDestination
participant AccountDestBuilder as AccountDestination.builder()
Client->>KtorRoute: POST /api/quotes (JSON body)
KtorRoute->>buildQuoteDestination: destNode (JsonNode)
alt has "umaAddress"
buildQuoteDestination-->>KtorRoute: UmaAddressDestination
else account destination
buildQuoteDestination->>AccountDestBuilder: .accountId(...)
Note over buildQuoteDestination,AccountDestBuilder: NEW: optionally set paymentRail
alt destNode has "paymentRail"
buildQuoteDestination->>AccountDestBuilder: .paymentRail(value)
end
AccountDestBuilder-->>buildQuoteDestination: AccountDestination
buildQuoteDestination-->>KtorRoute: QuoteDestinationOneOf
end
KtorRoute->>KtorRoute: quotes().create(params)
KtorRoute-->>Client: 201 Created (quote JSON)
Last reviewed commit: "chore: sync Kotlin s..."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
paymentRailfield added to quote account destinations in feat: adding paymentRail to quote account destination #279Context
The recent schema change (309c629) added an optional
paymentRailfield toAccountDestinationin quotes, allowing users to specify which payment rail to use for transfers.Changes
Kotlin Sample App:
buildQuoteDestination()inQuotes.ktto pass throughpaymentRailfrom input JSON when providedNo changes needed:
Test plan
paymentRailfieldpaymentRailcontinue to work🤖 Generated with Claude Code