Conversation
Add an InternalAccountType enum (INTERNAL_FIAT, INTERNAL_CRYPTO, EMBEDDED_WALLET) as a required field on InternalAccount and as an optional query filter on GET /internal-accounts. Needed so integrators can distinguish the self-custodial Embedded Wallet from platform-managed holding accounts on the same customer. Also updates the internal-account-status webhook example to carry the new required field.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This stack of pull requests is managed by Graphite. Learn more about stacking. |
✱ Stainless preview buildsThis PR will update the kotlin openapi python typescript
|
Greptile SummaryThis PR introduces Confidence Score: 5/5Safe to merge — all changes are additive and well-formed; the only finding is a P2 style suggestion. All six files are consistent with each other and with the build process. The single comment is a missing hyperlink in the EMBEDDED_WALLET description, which is a P2 style issue and does not block merge. No files require special attention.
|
| Filename | Overview |
|---|---|
| openapi/components/schemas/customers/InternalAccountType.yaml | New enum schema with three values (INTERNAL_FIAT, INTERNAL_CRYPTO, EMBEDDED_WALLET); well-formed and properly described. Minor: missing link in EMBEDDED_WALLET description. |
| openapi/components/schemas/customers/InternalAccount.yaml | Adds type as a required field with $ref to InternalAccountType; consistent placement and formatting with existing properties. |
| openapi/paths/internal-accounts/internal_accounts.yaml | Adds optional type query parameter using the new InternalAccountType enum schema; description is clear and practical. |
| openapi/webhooks/internal-account-status.yaml | Webhook example updated to include the new required type field with INTERNAL_FIAT value, keeping the example schema-valid. |
| openapi.yaml | Generated bundle reflecting all source changes; identical diff to mintlify/openapi.yaml as expected from make build. |
| mintlify/openapi.yaml | Mintlify-targeted generated bundle; changes are identical to the root openapi.yaml bundle, consistent with the build process. |
Flowchart
%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[GET /internal-accounts] -->|optional ?type=| B{InternalAccountType filter}
B -->|INTERNAL_FIAT| C[Grid-managed fiat holding account]
B -->|INTERNAL_CRYPTO| D[Grid-managed crypto / stablecoin account]
B -->|EMBEDDED_WALLET| E[Self-custodial Embedded Wallet]
B -->|no filter| F[All account types returned]
G[InternalAccount response object] --> H[type: InternalAccountType REQUIRED]
H --> C
H --> D
H --> E
E -->|outbound transfers| I[Requires session signature from customer device]
Prompt To Fix All With AI
This is a comment left during a code review.
Path: openapi/components/schemas/customers/InternalAccountType.yaml
Line: 16-19
Comment:
**Missing link in `EMBEDDED_WALLET` description**
The description says "see the Embedded Wallets guide" but provides no URL or `$ref` to the actual guide. Integrators hitting this in the rendered docs won't know where to look for the session-signature flow details.
```suggestion
customer. Outbound transfers require a session signature produced by the
customer's device — see the [Embedded Wallets guide](/embedded-wallets).
```
How can I resolve this? If you propose a fix, please make it concise.Reviews (1): Last reviewed commit: "feat(openapi): add type discriminator to..." | Re-trigger Greptile
|
|
||
| - `EMBEDDED_WALLET`: A self-custodial Embedded Wallet provisioned for the | ||
| customer. Outbound transfers require a session signature produced by the | ||
| customer's device — see the Embedded Wallets guide. |
There was a problem hiding this comment.
Missing link in
EMBEDDED_WALLET description
The description says "see the Embedded Wallets guide" but provides no URL or $ref to the actual guide. Integrators hitting this in the rendered docs won't know where to look for the session-signature flow details.
| - `EMBEDDED_WALLET`: A self-custodial Embedded Wallet provisioned for the | |
| customer. Outbound transfers require a session signature produced by the | |
| customer's device — see the Embedded Wallets guide. | |
| customer. Outbound transfers require a session signature produced by the | |
| customer's device — see the [Embedded Wallets guide](/embedded-wallets). |
Prompt To Fix With AI
This is a comment left during a code review.
Path: openapi/components/schemas/customers/InternalAccountType.yaml
Line: 16-19
Comment:
**Missing link in `EMBEDDED_WALLET` description**
The description says "see the Embedded Wallets guide" but provides no URL or `$ref` to the actual guide. Integrators hitting this in the rendered docs won't know where to look for the session-signature flow details.
```suggestion
customer. Outbound transfers require a session signature produced by the
customer's device — see the [Embedded Wallets guide](/embedded-wallets).
```
How can I resolve this? If you propose a fix, please make it concise.
Add an InternalAccountType enum (INTERNAL_FIAT, INTERNAL_CRYPTO,
EMBEDDED_WALLET) as a required field on InternalAccount and as an
optional query filter on GET /internal-accounts. Needed so integrators
can distinguish the self-custodial Embedded Wallet from platform-managed
holding accounts on the same customer.
Also updates the internal-account-status webhook example to carry the
new required field.