Skip to content

chore: Sync account schemas #431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JasonCWang merged 1 commit into from
May 1, 2026
Merged

chore: Sync account schemas #431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions mintlify/openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions openapi.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion openapi/components/schemas/common/BdtBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- fullName
properties:
beneficiaryType:
Expand Down
1 change: 0 additions & 1 deletion openapi/components/schemas/common/GhsBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- fullName
properties:
beneficiaryType:
Expand Down
1 change: 1 addition & 0 deletions openapi/components/schemas/common/GtqBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ required:
- beneficiaryType
- countryOfResidence
- fullName
- phoneNumber
Copy link
Copy Markdown
Contributor

@greptile-apps greptile-apps Bot May 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Breaking change: phoneNumber newly required for GTQ

phoneNumber was previously optional in GtqBeneficiary and is now listed as a required field. Any existing client that submits a GTQ payment without phoneNumber will receive a validation error after this change goes live. The other five currency schemas in this PR only remove a required field (backwards-compatible), while this one adds one — which is a breaking change for consumers. Please confirm this is intentional and that downstream callers have been updated or given a migration window.

Prompt To Fix With AI 
This is a comment left during a code review.
Path: openapi/components/schemas/common/GtqBeneficiary.yaml
Line: 7

Comment:
**Breaking change: `phoneNumber` newly required for GTQ**

`phoneNumber` was previously optional in `GtqBeneficiary` and is now listed as a required field. Any existing client that submits a GTQ payment without `phoneNumber` will receive a validation error after this change goes live. The other five currency schemas in this PR only *remove* a required field (backwards-compatible), while this one *adds* one — which is a breaking change for consumers. Please confirm this is intentional and that downstream callers have been updated or given a migration window.

How can I resolve this? If you propose a fix, please make it concise.

Fix in Claude Code

properties:
beneficiaryType:
type: string
Expand Down
1 change: 0 additions & 1 deletion openapi/components/schemas/common/HtgBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- fullName
properties:
beneficiaryType:
Expand Down
1 change: 0 additions & 1 deletion openapi/components/schemas/common/JmdBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ type: object
required:
- beneficiaryType
- address
- countryOfResidence
- fullName
- phoneNumber
properties:
Expand Down
1 change: 0 additions & 1 deletion openapi/components/schemas/common/PkrBeneficiary.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ title: Individual Beneficiary
type: object
required:
- beneficiaryType
- countryOfResidence
- fullName
properties:
beneficiaryType:
Expand Down
Loading