fix: fixing umaaas urls after url migration#514
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jklein24
approved these changes
May 27, 2026
Contributor
Greptile SummaryThis PR updates UMA proxy target URLs in two documentation files, replacing the old
Confidence Score: 4/5Safe to merge after confirming whether the Both files correctly migrate the three proxy path examples to the new host. The one concern is line 20 of mintlify/global-p2p/getting-started/platform-configuration.mdx — line 20 references the old default domain and may need the same update.
|
| Filename | Overview |
|---|---|
| mintlify/global-p2p/getting-started/platform-configuration.mdx | Updates 3 proxy URL examples from .docs.lightspark.com to .grid.lightspark.com; one reference to docs.lightspark.com on line 20 (default domain mention) was not updated. |
| mintlify/snippets/platform-configuration-uma.mdx | Updates 3 proxy URL examples from .docs.lightspark.com to .grid.lightspark.com; no other stale references found in this file. |
Comments Outside Diff (1)
-
mintlify/global-p2p/getting-started/platform-configuration.mdx, line 20 (link)This line still references
docs.lightspark.comas the default domain, while the rest of this PR migrates all UMA-related URLs togrid.lightspark.com. If the underlying service has moved, users who skip configuring a UMA domain will be pointed at the old host.Prompt To Fix With AI
This is a comment left during a code review. Path: mintlify/global-p2p/getting-started/platform-configuration.mdx Line: 20 Comment: This line still references `docs.lightspark.com` as the default domain, while the rest of this PR migrates all UMA-related URLs to `grid.lightspark.com`. If the underlying service has moved, users who skip configuring a UMA domain will be pointed at the old host. How can I resolve this? If you propose a fix, please make it concise.
Prompt To Fix All With AI
Fix the following 1 code review issue. Work through them one at a time, proposing concise fixes.
---
### Issue 1 of 1
mintlify/global-p2p/getting-started/platform-configuration.mdx:20
This line still references `docs.lightspark.com` as the default domain, while the rest of this PR migrates all UMA-related URLs to `grid.lightspark.com`. If the underlying service has moved, users who skip configuring a UMA domain will be pointed at the old host.
```suggestion
If you do not configure an UMA domain, Grid will use the default domain `grid.lightspark.com`.
```
Reviews (1): Last reviewed commit: "fix: fixing umaaas urls after url migrat..." | Re-trigger Greptile
Contributor
|
Preview deployment for your docs. Learn more about Mintlify Previews.
|
pengying
added a commit
that referenced
this pull request
May 28, 2026
…es (#518) ## Summary Updates the Stainless config to reflect the current API surface and adds five new SDK targets. ### New SDK targets - `ruby` (gem `grid`, rubygems publish disabled) - `go` (package `grid`) - `csharp` (package `grid`, nuget publish disabled) - `php` (package `grid`, composer `org-placeholder/grid`) - `cli` (binary `grid`) All have `production_repo: null` for now. ### Resource sync - `config.models`: add `embedded_wallet_config` - `sandbox`: add `cards.simulate` subresource (authorization/clearing/return) with associated card simulation models - `$shared`: add `slv_external_account_create_info`, `slv_beneficiary`, `swift_external_account_create_info` - `customers.methods`: add `generate_kyc_link: post /customers/{customerId}/kyc-link` - `agents`: add `agent_account_restrictions`, `agent_approval_thresholds` - Add top-level `cards` resource (issue / list / retrieve / update) ### Auth credential verify-request aliases — intentionally omitted `email_otp_credential_verify_request`, `oauth_credential_verify_request`, and `passkey_credential_verify_request` are **not** added as model aliases. The auth verify-request schemas are defined as: ```yaml allOf: - $ref: AuthCredentialVerifyRequest - $ref: <X>CredentialVerifyRequestFields ``` Two existing `openapi.transforms` (lines stripping `type` from `AuthCredentialVerifyRequest.properties`, then removing the `$ref` from `allOf[0]` of each verify variant) reduce these to structurally equivalent to their `Fields` siblings. Stainless collapses the allOf and emits only the `<X>CredentialVerifyRequestFields` types in `credentials.ts`, so a model alias pointing to `<X>CredentialVerifyRequest` would generate broken imports (`TS2724` / `TS2552` in `auth.ts`, `credentials.ts`, `index.ts`). The create-side aliases work because `AuthCredentialCreateRequest` retains a non-`type` field (`accountId`) after the transform, so its variants don't collapse. ### Other - `organization.docs`: `docs.lightspark.com` → `grid.lightspark.com`. **Worth a second look** — recent commits (#513, #514) migrated *away* from `grid.lightspark.com` in the docs. Confirm this is intentional before merging. ## Notes Stacked on top of #517 (document request body refactor); no code dependency between the two — sequencing is just chronological.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.