Updates to core, ui, lightspark-sdk #436
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imals. (#13168)    GitOrigin-RevId: 365cf8e0bbb382e58706c319e7bd464766b9adf1
Contributor
Author
|
The following public packages have changed files:
There are 3 existing changesets for this branch. If additional changes have been made that require different versions for any package simply add another changeset. Any packages that depend on the planned releases will be updated and released automatically in a separate PR. Each changeset corresponds to an update in the CHANGELOG for the packages listed in the changeset. Therefore, you should add a changeset for each noteable package change that this PR contains. For example, if a PR adds two features - one feature for packages A and B and one feature for package C - you should add two changesets. One changeset for packages A and B and one changeset for package C, with a description of each feature. The feature description will end up being the CHANGELOG entry for the packages in the changeset. The following releases are planned based on the existing changesets:
Last updated by commit c322cc8 |
@ch-brian noticed a weird issue where a TextInput in a Modal was losing focus on the second Modal open. The issue was that visibleChanged was not synced to the render cycle, causing an incorrect value read on the next render, triggering the auto focus function of the Modal to the default focus target at the wrong time. GitOrigin-RevId: 2a8b49e741b97ee9f8183ed4553db31076acee5f
GitOrigin-RevId: 7aaedd8deda222983fb7a8c42ab69e6e39e6ea51
GitOrigin-RevId: 65955114b5d293e84d15b8e62122ba6f3160fc10
GitOrigin-RevId: 7951805cc46cbe9f3f42389a4eb0f4f401b66d04
…. (#13261) Surfacing the bitcoin fee estimates into Ops side and created ToolTip to show it on OpsHeader.  GitOrigin-RevId: e8b132089a9f0f762ed2ff745e2fbe85042786a9
… (#13147) GitOrigin-RevId: cf2f33b84b464a08e2e4edac4c8a94a6e2d870de
# create & manage uma invites create invite bridge page basic invites page and invite details modal switching everything to modals most pages in place, but the ui is janky add missing files adding lots of icons further small styling add invites feature gating GitOrigin-RevId: accec2f82306535020716eda013d6fe9ddecee2a
Moves recaptcha to a service for better control of script loading sequence and error handling. If recaptcha fails it surfaced as an error to the user advising them to reload the page and tracked in frontend logs. Instead of trying to run mutations with empty string as recaptcha token this will fail early and display an error to the user. We can be more clever about this in the future and try reloading the script a few times if we continue seeing a lot of these errors in logs. Let's monitor these changes first. <img width="690" alt="Screenshot 2024-11-06 at 10 48 33 PM" src="https://github.com/user-attachments/assets/42fdf777-3a2e-4688-8153-67b0cc07179d"> GitOrigin-RevId: 8516671aee3369231c498f468b01ac850c461a7e
See thread for more context https://lightsparkgroup.slack.com/archives/C07TU530878/p1731449754721009 <img width="725" alt="Screenshot 2024-11-12 at 10 58 39 PM" src="https://github.com/user-attachments/assets/fabe5e3a-273f-46e7-b6ee-183e9fe56210"> GitOrigin-RevId: 43f11bd16b21aefec998b705b6cf2bea5eb0a8e4
…or the corresponding unit (#13403) GitOrigin-RevId: 60b15667c084c85734b889fc21e4e38a622897d1
https://github.com/user-attachments/assets/9b5a4f03-0809-4e8f-96e2-990e2d64c1b0 GitOrigin-RevId: d35f6f9e6e151b351864e392c89c3f5a296c15c5
https://github.com/user-attachments/assets/0b644482-8b6e-4522-b3c5-d14622f6347e GitOrigin-RevId: f5633a139605049869a4d8c3a459d017a95ad578
<img width="732" alt="Screenshot 2024-11-14 at 5 33 55 PM" src="https://github.com/user-attachments/assets/23b890a4-71de-4f97-b02b-824695282bd0"> GitOrigin-RevId: b6ed44d00fb0a282409969ee72e43ebc5a6c997c
…r icons (#13501) - Add a `square` prop to Icons to force square aspect ratio. This was important here to ensure consistent padding on round icon buttons regardless of icon width. - Move some one-off paddings from Button to theme defaults. - `roundSingleChar` and `roundIcon` are now theme button kinds with specific paddings. They are set as the default kind when Button detects either scenario from button props. <img width="725" alt="Screenshot 2024-11-18 at 5 51 41 PM" src="https://github.com/user-attachments/assets/0d9f37f6-f06b-4484-b131-102dc6cef297"> GitOrigin-RevId: 72fe0fb76d6ca76ad01ef09f9506ba8331eb17d4
GitOrigin-RevId: 114dc768c3eef689493b02621db63be05cbf0c50
- iOS only allows autofocus (pulling up keyboard automatically on each send screen) when the input is shown synchronously in response to a user event. We can ease the UX in general by debouncing and running `lookup_estimated_currency_conversions` while the user types so the lnurlp is ready when user clicks "Continue". And this way the amount input can be autofocused. https://github.com/user-attachments/assets/9262db64-d008-4ecc-a43b-c41ce330dab7 GitOrigin-RevId: 4bb880ee550eddfb78b0cfe78b5932bac3a9e960
GitOrigin-RevId: 3c7c9127089992a46a4966df93632aea0dd4e5c9
GitOrigin-RevId: 9b3e0072ee8c8fd259770a6bf9b56e54ade85b4f
Change these to `/ui/logs` and `/ui/event/<token>` so we can use a single routing path on the LB. GitOrigin-RevId: 20d08168eff9eeb756e7ccef27c41ee229e63fe2
GitOrigin-RevId: 66cc08ae7f7150b7ffa11655d13ea36154ba61fd
- Can pass in a custom header to display above the data manager table. This header is displayed inline with the filter button. Filter button is also now positioned absolutely so the custom header can scroll underneath it if needed. - Allows single icon buttons to be completely round - Creates an option to remove the bottom border on ButtonRow GitOrigin-RevId: f1ac44e9bbcf88fa741ccf1b508b9f5416db9b93
GitOrigin-RevId: 4a5d0511f8fd41163c549c49a937fa735f5bac8f
GitOrigin-RevId: b38c948a5b1d252ca03943a2067caf9626e96cc3
GitOrigin-RevId: 3252522c26a1bbf3a191baa0555a845c946565b6
https://github.com/user-attachments/assets/c392c186-d818-4533-8518-3d2020069620 --------- Co-authored-by: Corey Martin <coreyn.martin@gmail.com> GitOrigin-RevId: 271befae14d253186a888e4adc99c925b916d7db
…aded logo along with the name. Update onhover styling so it does not overlap with the logo. (#14664) This change updates the stablecoin issuance ui to display the logo alongside the name. This change was achieved by adding the ability to add custom base 64 icons to the Table component. Border styling on hover was also updated to encompass the elements within a table row.  GitOrigin-RevId: 1ae4cc2e2eafc53a8913334ac0aa64638df8c96e
GitOrigin-RevId: 83a6bd25f93b0e95d2817f5c69910f6663c26562
… current language is es (#14690) - Ensure the string requested from getString actually exists on the translations object. - Set localization for dates when current language is `es` GitOrigin-RevId: 7130cc6da80e069dcea8e6e49540474aada49e0f
This will be used to indicate if `resultCount` is the full count, or if it's merely a lower bound on the number of results. If the latter, show `1-20 of 1000+` rather than `1-20 of 1000`. Contributes to LIG-7021 . GitOrigin-RevId: 1235744cb58e10bc310f8cc26ad79c564ee2d3cf
Follow up from #14273 . GitOrigin-RevId: 70062c422f68ae7f2bb82674fb12caf23c19288c
…in a tr. table is configurable to use the original border style as well. table defaults to original border styles. (#14730)
This change adds consistent styling to onhover table effects across webkit and chromium browsers as a background hover effect encapsulating the entire table row.
This is a new option to the Table component available as rowHoverEffect: "background". The table component defaults to the original "border" implementation that provides a border effect on hover.
Before:
<div class='graphite__hidden'>
<div>🎥 Video uploaded on Graphite:</div>
<a href="https://app.graphite.dev/media/video/AMCzR6ldnuRamjbkxWC9/d263d3d9-be34-452b-a68a-06347840c57b.mov">
<img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/AMCzR6ldnuRamjbkxWC9/d263d3d9-be34-452b-a68a-06347840c57b.mov">
</a>
</div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/AMCzR6ldnuRamjbkxWC9/d263d3d9-be34-452b-a68a-06347840c57b.mov">Screen Recording 2025-01-07 at 3.25.23 PM.mov</video>
After:
<div class='graphite__hidden'>
<div>🎥 Video uploaded on Graphite:</div>
<a href="https://app.graphite.dev/media/video/AMCzR6ldnuRamjbkxWC9/fc4caf41-def4-44e4-9c44-06bd9b87b307.mov">
<img src="https://app.graphite.dev/api/v1/graphite/video/thumbnail/AMCzR6ldnuRamjbkxWC9/fc4caf41-def4-44e4-9c44-06bd9b87b307.mov">
</a>
</div>
<video src="https://graphite-user-uploaded-assets-prod.s3.amazonaws.com/AMCzR6ldnuRamjbkxWC9/fc4caf41-def4-44e4-9c44-06bd9b87b307.mov">Screen Recording 2025-01-07 at 3.23.50 PM.mov</video>
GitOrigin-RevId: 658caaeb89c958cfdc04cfa922875e9950b1203e
GitOrigin-RevId: 61556c675a6fb45db8f056a67a2ebdbe6cdfeedf
# New birthday input field provides validation of birthday strings, formats with slants closes LIG-7200  GitOrigin-RevId: 019a2b21cc22254fc0ceb35c7cff8bb50d05a4c5
GitOrigin-RevId: 3d8e23dde8cb6bd432b5421923562459699354f1
…end receiving currency (#14874) GitOrigin-RevId: 2527aab5050313fc2e98ab6d384cc13b7449731d
GitOrigin-RevId: e10d7698028887bd25adda8a4221a2041531e3cf
https://lightsparkgroup.slack.com/archives/C0447HDL3LY/p1737044979159579 GitOrigin-RevId: 32310ff3823b5cbf8b64d71afe34a5838b883290
…t (#14909) Also start defaulting to non lowercase, non plural appended units everywhere. This should have already been the default. GitOrigin-RevId: 4f5db9dc9098b257daaf54ca14220397691cd653
Show the three most recent successful transaction addresses as recommended receivers. https://github.com/user-attachments/assets/0b431c0b-a76f-48e7-833f-28568e4db7da GitOrigin-RevId: 57097b7c73de29a72dbfbbc792f142fb6b621edc
GitOrigin-RevId: 3307d7aa7b51b2f9cb4c59dbaebf0e37e45ebf65
… readability in both light and dark mode (#14744) This change updates the styles on CreateTokenInvitation to support readability in both light and dark mode. Before:   After:   GitOrigin-RevId: 1e37f28406e42ac70800fc849c35f77cfb92f27c
GitOrigin-RevId: 9f184dabc74f0433a34f098edc7f29fb8aec42ee
GitOrigin-RevId: 11ae0968191cf22de8f29f7272338e54ad3dc662
<img width="558" alt="Screenshot 2025-01-29 at 7 12 16 PM" src="https://github.com/user-attachments/assets/f9cb5aed-de80-400d-9f72-397afcf046b0" /> GitOrigin-RevId: 14ab7a752d70894cccd1c8053a7f43ab5f204bbf
GitOrigin-RevId: 05e22007251c8caea234f51aaf581d584c515d18
GitOrigin-RevId: 493aedc911cf977d32e1000167634cc053b170b1
Some key insights: - checking for any redirect happens in a single reduce function and executed afterwards - user-related steps are organized into easy to read arrays and can easily be reordered - the user type can't be inferred in the actual predicate function bc it doesn't know what vaspUser type is being passed in, so i needed to do this (this is where i think having clear interfaces would help) - I separated the concept of redirects that happen as a result of user state vs other criteria. This way any user-related routing can clearly be defined and the predicate is passed in the user query object GitOrigin-RevId: d7c05174a396f9b7a5fd6def07dce40be376c450
GitOrigin-RevId: 9b241f86bb52a2904abdb64382cebef55600befe
coreymartin
changed the title
coreymartin
approved these changes
Feb 5, 2025
jklein24
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If this change should result in new package versions please add a changeset before merging. You can do so by clicking the link provided by changeset bot below.