Refactor token architecture for clarity and consistency#112
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BREAKING CHANGE: 20 tokens removed, 12 added, values changed on --border-primary. ## Token Rename Map Old Token → New Token --border-tertiary → --border-primary --border-inverted → --border-inverse --surface-inverted → --surface-inverse --surface-inverted-hover → --surface-inverse-hover --surface-strong → --surface-neutral --surface-elevated → --surface-panel --surface-sunken → --surface-secondary --text-surface → --text-inverse --icon-surface → --icon-inverse --icon-inverted → --icon-inverse --input-focus (color) → --state-focus --input-focus-critical (color) → --state-focus-critical Note: --input-focus/--input-focus-critical in _effects.scss (full box-shadow values) are unchanged. Only the color tokens moved to state-*. ## New Tokens --border-focus Solid border for focus outlines (split from old --border-primary) --stroke-primary Solid stroke for charts/data visualization only --surface-panel Background for floating UI: dialogs, tooltips, popovers, action bars --text-link Link text color ## Removed Tokens (no replacement) --border-hover, --text-muted, --surface-active, --surface-selected, --surface-inverted-backdrop, --icon-info-inverted, --icon-success-inverted, --icon-warning-inverted, --icon-critical-inverted ## Silent Value Change: --border-primary --border-primary still exists but changed value from solid to alpha: - Light: #1A1A1A → rgba(38, 38, 35, 0.10) - Dark: #F8F8F7 → rgba(244, 244, 245, 0.10) This will NOT surface as a build error. Consumers using --border-primary directly should audit: - Focus outlines → switch to --border-focus - Chart strokes → switch to --stroke-primary - Default UI borders (dividers, card edges) → no action, alpha is correct ## Dark Mode Surface Recalibration --surface-panel: #111111 → #212121 (lifts panels above --surface-primary) --surface-secondary: #282828 → #111111 (recedes behind --surface-primary) ## Consumer Migration No sequencing required. Bump Origin, find-and-replace old token names, audit --border-primary and --input-focus usage, test dark mode. Made-with: Cursor
jaymantri
force-pushed
the
refactor/token-architecture
branch
from
c63a55a to
2760f67
Compare
coreymartin
approved these changes
Feb 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inverted→inverse,tertiary→primary,elevated→panel)--border-focus,--stroke-primary,--surface-panel,--text-linkstatetoken group for focus-ring colors (--state-focus,--state-focus-critical)Key Renames
--surface-elevated--surface-panel--border-tertiary--border-primary--surface-strong--surface-neutral*-invertedtokens*-inverseSee commit message for the full rename map.
Breaking Changes
Silent value change:
--border-primarychanged from solid (#1A1A1A) to alpha (rgba(38, 38, 35, 0.10)). This will not cause build errors but may cause visual regressions in consumers using it directly for focus outlines or chart strokes. See commit message for full migration guide.Removed tokens will resolve to nothing — consumers must find-and-replace using the rename map in the commit message.
Consumer Migration
No sequencing required. Bump Origin, find-and-replace old token names, audit
--border-primaryand--input-focususage, test dark mode. Full migration guide is in the commit message.Test Plan