Harden Drawer side panels and nested stacking#124
Merged
Conversation
Add --drawer-surface, --drawer-radius, --drawer-margin, and --drawer-height-override so consumers can style inset floating panels without !important overrides. Hide the ::before bleed pseudo-element on side and top panels. Fix expanded-state styles on top sheets being lost due to source-order specificity. Made-with: Cursor
Extend `Drawer.Popup` with opt-in stacked motion for side panels and top sheets so nested flows no longer need product-level transform hacks, and document when to use stacked drawers versus indented shell layouts. Made-with: Cursor
Align Drawer.Popup with the requested default tokens by using surface-primary and border-primary, and lock the styling in with a focused component test. Made-with: Cursor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
coreymartin
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
!importantoverridesTest plan
npm run lintnpm test -- src/components/Drawer/Drawer.test.tsxMade with Cursor