Skip to content

rename ADDRESS to POSTAL_ADDRESS#231

Merged
shreyav merged 1 commit intomainfrom
10-15-rename_address_to_postal_address
Oct 15, 2025
Merged

rename ADDRESS to POSTAL_ADDRESS#231
shreyav merged 1 commit intomainfrom
10-15-rename_address_to_postal_address

Conversation

@shreyav
Copy link
Copy Markdown
Contributor

@shreyav shreyav commented Oct 15, 2025

No description provided.

Copy link
Copy Markdown
Contributor Author

shreyav commented Oct 15, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@shreyav shreyav marked this pull request as ready for review October 15, 2025 20:13
@shreyav shreyav requested a review from pengying October 15, 2025 20:13
}
"ADDRESS" -> {
builder.putAdditionalProperty("ADDRESS", JsonValue.from(Address.builder()
"POSTAL_ADDRESS" -> {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh hmmm I think this will create a json object vs a stringifed json object

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the example to show that it would be a json object

@shreyav shreyav force-pushed the 10-15-rename_address_to_postal_address branch 3 times, most recently from 9a61df5 to d9b6609 Compare October 15, 2025 22:52
@shreyav shreyav requested a review from jklein24 October 15, 2025 22:56
@shreyav shreyav merged commit 8877679 into main Oct 15, 2025
7 checks passed
@shreyav shreyav deleted the 10-15-rename_address_to_postal_address branch October 15, 2025 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants