LCORE-158: Config unit tests improvements

tests/unit/models/test_config.py

@@ -92,6 +92,8 @@ def test_user_data_collection_collection_enabled() -> None:
     # correct configuration
     cfg = UserDataCollection(feedback_disabled=True, feedback_storage=None)
     assert cfg is not None
+    assert cfg.feedback_disabled is True
+    assert cfg.feedback_storage is None
 
 
 def test_user_data_collection_colection_disabled() -> None:

tests/unit/test_configuration.py

@@ -17,6 +17,10 @@ def test_default_configuration() -> None:
         # try to read property
         cfg.llama_stack_configuration
 
+    with pytest.raises(Exception, match="logic error: configuration is not loaded"):
+        # try to read property
+        cfg.user_data_collection_configuration
+
 
 def test_configuration_is_singleton() -> None:
     cfg1 = AppConfig()
@@ -46,11 +50,32 @@ def test_init_from_dict() -> None:
     }
     cfg = AppConfig()
     cfg.init_from_dict(config_dict)
+
+    # check for all subsections
     assert cfg.configuration is not None
     assert cfg.llama_stack_configuration is not None
     assert cfg.service_configuration is not None
     assert cfg.user_data_collection_configuration is not None
 
+    # check for configuration subsection
+    assert cfg.configuration.name == "foo"
+
+    # check for llama_stack_configuration subsection
+    assert cfg.llama_stack_configuration.api_key == "xyzzy"
+    assert cfg.llama_stack_configuration.url == "http://x.y.com:1234"
+    assert cfg.llama_stack_configuration.use_as_library_client is False
+
+    # check for service_configuration subsection
+    assert cfg.service_configuration.host == "localhost"
+    assert cfg.service_configuration.port == 8080
+    assert cfg.service_configuration.auth_enabled is False
+    assert cfg.service_configuration.workers == 1
+    assert cfg.service_configuration.color_log is True
+    assert cfg.service_configuration.access_log is True
+
+    # check for user data collection subsection
+    assert cfg.user_data_collection_configuration.feedback_disabled is True
+
 
 def test_load_proper_configuration(tmpdir) -> None:
     cfg_filename = tmpdir / "config.yaml"