Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Jan 28, 2026

Description

LCORE-891: fix Pyright issues in test/utils

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-891

Summary by CodeRabbit

  • Tests
    • Updated internal test suite to ensure proper configuration validation across various scenarios, including enriched configuration objects and type handling consistency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jan 28, 2026

Walkthrough

Test files updated to use Path objects in file/directory check calls, extend configuration objects with required service parameters (host, port, base_url, auth_enabled, workers, color_log, access_log), add fields to LlamaStackConfiguration and UserDataCollection, include provider_id in ModelContextProtocolServer, and refactor an assertion with an intermediate variable.

Changes

Cohort / File(s) Summary
File/Directory Check Tests
tests/unit/utils/test_checks.py
Updated test calls to pass Path objects instead of string paths to file_check and directory_check functions; assertions for existing, non-existing, unreadable, and writable paths now wrap inputs with Path(...)
Configuration Object Tests
tests/unit/utils/test_common.py
Extended test constructors with populated ServiceConfiguration fields (host, port, base_url, auth_enabled, workers, color_log, access_log); added library_client_config_path and api_key to LlamaStackConfiguration; expanded UserDataCollection with transcripts_storage and feedback_storage; added provider_id to ModelContextProtocolServer entries
Type Parsing Tests
tests/unit/utils/test_types.py
Refactored assertion for tool_parser.get_tool_calls(None) to use intermediate result variable with pyright ignore comment; no functional changes to test behavior

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and specifically describes the main purpose of the changeset: fixing Pyright type-checking issues in test utilities. It references the ticket number and identifies the affected directory.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 1c081a6 into lightspeed-core:main Jan 28, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant