-
Notifications
You must be signed in to change notification settings - Fork 70
LCORE-1280: docs update #1092
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-1280: docs update #1092
Conversation
WalkthroughThis PR updates configuration documentation and API specifications to reflect new features including A2A state management, Azure Entra ID authentication, Splunk integration, and timeout configurations for Llama Stack and MCP servers. All changes are documentation-only across schema definitions and OpenAPI specifications. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (2)
docs/openapi.md (1)
4859-4865:⚠️ Potential issue | 🟡 MinorFix markdownlint MD060 table alignment for the timeout row.
The linter flags this row for column alignment; aligning the table resolves it.
🧹 Suggested alignment fix
-| Field | Type | Description | -|-------|------|-------------| -| url | | URL to Llama Stack service; used when library mode is disabled | -| api_key | | API key to access Llama Stack service | -| use_as_library_client | | When set to true Llama Stack will be used in library mode, not in server mode (default) | -| library_client_config_path | | Path to configuration file used when Llama Stack is run in library mode | -| timeout | integer | Timeout in seconds for requests to Llama Stack service. Default is 180 seconds (3 minutes) to accommodate long-running RAG queries. | +| Field | Type | Description | +|----------------------------|---------|-------------| +| url | | URL to Llama Stack service; used when library mode is disabled | +| api_key | | API key to access Llama Stack service | +| use_as_library_client | | When set to true Llama Stack will be used in library mode, not in server mode (default) | +| library_client_config_path | | Path to configuration file used when Llama Stack is run in library mode | +| timeout | integer | Timeout in seconds for requests to Llama Stack service. Default is 180 seconds (3 minutes) to accommodate long-running RAG queries. |docs/openapi.json (1)
4287-4312:⚠️ Potential issue | 🟠 MajorFix duplicate
operationIdon /a2a GET vs POST.
operationIdmust be unique in OpenAPI; both GET and POST are currently set tohandle_a2a_jsonrpc_a2a_post, which will cause generator and client conflicts. Rename the GET operationId tohandle_a2a_jsonrpc_a2a_getor remove the GET operation if intentionally deprecated.🛠️ Suggested fix (rename GET operationId)
- "operationId": "handle_a2a_jsonrpc_a2a_post", + "operationId": "handle_a2a_jsonrpc_a2a_get",
🧹 Nitpick comments (1)
docs/config.json (1)
430-434: Consider consistency:a2a_stateuses direct$refwithoutanyOf/nullpattern.Other optional configuration fields like
azure_entra_idandsplunkuse theanyOf: [$ref, null]pattern withdefault: null. Thea2a_statefield uses a direct$refwithout this pattern, which could imply it's always required or has an implicit default object.If
a2a_stateis intended to be optional with a null default (like other similar fields), consider updating it to match the pattern used forazure_entra_idandsplunk.
Description
LCORE-1280: docs update
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit
Documentation