Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Feb 9, 2026

Description

LCORE-1218: updated config and OpenAPI docs

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1218

Summary by CodeRabbit

  • Documentation

    • Clarified configuration descriptions for vector database and URL requirements, specifying HTTP/HTTPS URL validation.
  • New Features

    • Added new ConversationTurn and Message models to the API.
    • Added timeout configuration option.
    • Enhanced error reporting with additional context fields.
  • Improvements

    • Strengthened URL validation with format enforcement across configuration and documentation endpoints.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Feb 9, 2026

Walkthrough

Documentation and schema files were updated with refined descriptions for configuration fields, stricter URL validation constraints (URI format and minLength requirements), and expanded error schema definitions with new context fields.

Changes

Cohort / File(s) Summary
Configuration description updates
docs/config.html, docs/config.md
Updated descriptions: ByokRag.vector_db_id expanded to "Vector database identification," and LlamaStackConfiguration.url extended to specify HTTP/HTTPS URL requirement.
Type and schema refinements
docs/config.puml, docs/openapi.json, docs/openapi.md
LlamaStackConfiguration.url type changed to AnyHttpUrl with URI format validation; added minLength and URI format constraints to ReferencedDocument.doc_url; expanded ValidationError schema with input and ctx fields; added ConversationTurn and Message models to OpenAPI documentation.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main changes: updates to configuration documentation (docs/config.html, docs/config.md, docs/config.puml) and OpenAPI documentation (docs/openapi.json, docs/openapi.md).
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Fix all issues with AI agents
In `@docs/openapi.json`:
- Around line 6976-6988: The schema for the property titled "Llama Stack URL"
currently allows any URI scheme via "format": "uri" but the description requires
only HTTP/HTTPS; update the schema for "Llama Stack URL" to enforce HTTP/HTTPS
(while still allowing null) by adding a scheme constraint such as a pattern like
^https?:// or an enum/oneOf that limits schemes to http and https (keep the
anyOf null branch intact); modify the schema near the "title": "Llama Stack URL"
entry so validation rejects non-HTTP schemes.

Comment on lines 6976 to 6988
"anyOf": [
{
"type": "string"
"type": "string",
"minLength": 1,
"format": "uri"
},
{
"type": "null"
}
],
"title": "Llama Stack URL",
"description": "URL to Llama Stack service; used when library mode is disabled"
"description": "URL to Llama Stack service; used when library mode is disabled. Must be a valid HTTP or HTTPS URL."
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Schema doesn’t enforce HTTP/HTTPS despite the description.

The description says HTTP/HTTPS only, but format: uri allows any scheme. This can let non-HTTP URLs pass schema validation. Consider constraining the scheme to match the description.

🛠️ Suggested schema tightening
                     "url": {
                         "anyOf": [
                             {
                                 "type": "string",
                                 "minLength": 1,
-                                "format": "uri"
+                                "format": "uri",
+                                "pattern": "^https?://"
                             },
                             {
                                 "type": "null"
                             }
                         ],
🤖 Prompt for AI Agents
In `@docs/openapi.json` around lines 6976 - 6988, The schema for the property
titled "Llama Stack URL" currently allows any URI scheme via "format": "uri" but
the description requires only HTTP/HTTPS; update the schema for "Llama Stack
URL" to enforce HTTP/HTTPS (while still allowing null) by adding a scheme
constraint such as a pattern like ^https?:// or an enum/oneOf that limits
schemes to http and https (keep the anyOf null branch intact); modify the schema
near the "title": "Llama Stack URL" entry so validation rejects non-HTTP
schemes.

@tisnik tisnik merged commit 44ca0fa into lightspeed-core:main Feb 9, 2026
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant