LCORE-1323: Add text/event-stream Header for Streaming Query#1145
LCORE-1323: Add text/event-stream Header for Streaming Query#1145tisnik merged 2 commits intolightspeed-core:mainfrom
Conversation
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
WalkthroughSets a new constant Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Signed-off-by: Jordan Dubrick <jdubrick@redhat.com>
jrobertboos
left a comment
There was a problem hiding this comment.
Overall the PR looks good. However could you make an issue in the LCORE JIRA and attach it to the PR, we are just trying to get better about attaching PR's to issues.
The ticket should be in the title like:
LCORE-XXX: Add text/event-stream Header for Streaming Query
As well as in the Closes Ticket section of the PR description.
Thanks so much!
Description
text/event-streamheader back after it was dropped during the refactor and defaulted totext/plainType of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit
Bug Fixes
New Features
Tests