Skip to content

LCORE-1437: Enable linter rule B010#1297

Merged
tisnik merged 3 commits intolightspeed-core:mainfrom
tisnik:lcore-1437-b010-linter-rule
Mar 10, 2026
Merged

LCORE-1437: Enable linter rule B010#1297
tisnik merged 3 commits intolightspeed-core:mainfrom
tisnik:lcore-1437-b010-linter-rule

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Mar 10, 2026

Description

LCORE-1437: Enable linter rule B010

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1437

Summary by CodeRabbit

  • Chores

    • Expanded linting rule set to enforce additional code quality standards.
  • Refactor

    • Optimized internal attribute access patterns for improved code clarity.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

Warning

Rate limit exceeded

@tisnik has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 16 minutes and 35 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 9f8e456c-84b4-4e15-83a3-fd18ae71a903

📥 Commits

Reviewing files that changed from the base of the PR and between 902320e and 3f1c3c9.

📒 Files selected for processing (1)
  • src/app/endpoints/streaming_query.py

Walkthrough

The PR extends the ruff linting rule set by adding B009 to the enabled rules and refactors response attribute access in the streaming query endpoint from dynamic (getattr) to direct attribute access.

Changes

Cohort / File(s) Summary
Linting Configuration
pyproject.toml
Added B009 to ruff lint extend-select rules for expanded rule coverage.
Response Attribute Access
src/app/endpoints/streaming_query.py
Replaced getattr() calls with direct attribute access for chunk.response in two event type branches (response.completed and response.incomplete/failed).

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Title check ⚠️ Warning The PR title states 'Enable linter rule B010' but the actual changes enable rule B009 in pyproject.toml, not B010. This is misleading. Update the PR title to accurately reflect the enabled linter rule, e.g., 'LCORE-1437: Enable linter rule B009' or clarify if B010 was the intended change.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit b9e971b into lightspeed-core:main Mar 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant