Skip to content

LCORE-1438: better string format#1303

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1438-better-string-format
Mar 10, 2026
Merged

LCORE-1438: better string format#1303
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1438-better-string-format

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Mar 10, 2026

Description

LCORE-1438: better string format

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1438

Summary by CodeRabbit

  • Style
    • Enhanced error message formatting in API endpoints and health check logic.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 10, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ea92dd9c-cf7b-458b-8465-95b17fdf20e2

📥 Commits

Reviewing files that changed from the base of the PR and between 36c2ae2 and e9304cf.

📒 Files selected for processing (2)
  • src/app/endpoints/a2a.py
  • src/app/endpoints/health.py

Walkthrough

Minor formatting changes in error message construction across two endpoint files. Both replace explicit str(e) casting with {e!s} format string conversion specifier in exception handling paths. No control flow or logic modifications.

Changes

Cohort / File(s) Summary
Error Message Formatting
src/app/endpoints/a2a.py, src/app/endpoints/health.py
Updated error message string formatting to use {e!s} conversion specifier instead of {str(e)} in exception interpolation for APIConnectionError and health check error paths.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing str(e) with {e!s} for better string formatting in error messages across two files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit de8a85a into lightspeed-core:main Mar 10, 2026
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant