Skip to content

refactor: consolidate MCP server registration into single async function#135

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
eranco74:fixup
Jun 26, 2025
Merged

refactor: consolidate MCP server registration into single async function#135
tisnik merged 1 commit into
lightspeed-core:mainfrom
eranco74:fixup

Conversation

@eranco74
Copy link
Copy Markdown
Contributor

Description

  • Remove register_mcp_servers function and merge its logic into register_mcp_servers_async
  • Fix unit tests to properly await register_mcp_servers_async calls
  • Update test configurations to use sync flow (use_as_library_client=False)

This simplifies the API by having a single entry point for MCP server registration.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

- Remove register_mcp_servers function and merge its logic into register_mcp_servers_async
- Fix unit tests to properly await register_mcp_servers_async calls
- Update test configurations to use sync flow (use_as_library_client=False)

This simplifies the API by having a single entry point for MCP server registration.
@tisnik
Copy link
Copy Markdown
Contributor

tisnik commented Jun 26, 2025

@manstis PTAL

Copy link
Copy Markdown
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

So you found a way to rewrite your tests.

@tisnik tisnik merged commit efb7071 into lightspeed-core:main Jun 26, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants