refactor: consolidate MCP server registration into single async function#135
Merged
Conversation
- Remove register_mcp_servers function and merge its logic into register_mcp_servers_async - Fix unit tests to properly await register_mcp_servers_async calls - Update test configurations to use sync flow (use_as_library_client=False) This simplifies the API by having a single entry point for MCP server registration.
Contributor
|
@manstis PTAL |
manstis
approved these changes
Jun 26, 2025
Contributor
manstis
left a comment
There was a problem hiding this comment.
LGTM 👍
So you found a way to rewrite your tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This simplifies the API by having a single entry point for MCP server registration.
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing