RSPEED-2658: Remove dead GraniteToolParser and legacy Agents API imports#1350
Conversation
…imports The GraniteToolParser class was a workaround for llama-stack-client-python#206, built for the old Agents API. The codebase has migrated to the Responses API and this class has zero production callers. Remove it, its legacy imports from llama_stack_client.lib.agents, and the corresponding unit tests. Signed-off-by: Major Hayden <major@redhat.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
💤 Files with no reviewable changes (2)
WalkthroughThe GraniteToolParser class and its related imports are being removed from the types module, along with corresponding unit tests. The changes eliminate unused tooling functionality previously exported from the utilities layer. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can disable sequence diagrams in the walkthrough.Disable the |
tisnik
left a comment
There was a problem hiding this comment.
Cool, code deletion, not slop addition ;)
Description
The
GraniteToolParserclass was a workaround for llama-stack-client-python#206, built for the old Agents API. The codebase has migrated to the Responses API and this class has zero production callers. This removes it, its legacy imports fromllama_stack_client.lib.agents(AgentCompletionMessage,AgentToolCall), and the corresponding unit tests.Type of change
Tools used to create PR
Related Tickets & Documents
Checklist before requesting a review
Testing
Pure deletion of dead code (103 lines removed, 0 added). Verified via grep that
GraniteToolParser,AgentCompletionMessage, andAgentToolCallhave zero remaining references in the codebase. No new tests needed since this only removes unused code and its tests.Summary by CodeRabbit
Release Notes