LCORE-1392: Updated dependencies#1365
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (6)
💤 Files with no reviewable changes (1)
✅ Files skipped from review due to trivial changes (5)
WalkthroughUpdated dependency declarations, lock/hash files, and Tekton pipeline prefetch lists: Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip CodeRabbit can use OpenGrep to find security vulnerabilities and bugs across 17+ programming languages.OpenGrep is compatible with Semgrep configurations. Add an |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
pyproject.toml (1)
61-61: Looseningurllib3constraint may reduce build reproducibility.Changing from an exact pin (
==2.6.3) to a lower-bounded range (>=2.6.3) allows the resolver to pick any version at or above 2.6.3. While this provides flexibility, it may reduce reproducibility across environments. Consider whether the exact pin was intentional for stability reasons.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@pyproject.toml` at line 61, The change to "urllib3>=2.6.3" loosens the dependency pin and can harm reproducibility; revert to the exact pin "urllib3==2.6.3" in pyproject.toml if the original exact version was required for stability, or tighten the constraint (e.g., "urllib3>=2.6.3,<3.0" or "urllib3==2.6.3") and add a brief comment explaining why that choice was made so future reviewers know whether the loosening was intentional.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@pyproject.toml`:
- Around line 191-197: Remove the duplicate/conflicting package entries in the
pyproject toml groups: in the "Lightspeed providers" list remove "numpy>=1.24.0"
(conflicts with the pinned "numpy==2.3.5" in the llslibdev group) and remove the
redundant "mcp>=1.23.0" (already present in llslibdev); keep the single
authoritative numpy==2.3.5 pin and one mcp>=1.23.0 entry to avoid resolver
conflicts.
---
Nitpick comments:
In `@pyproject.toml`:
- Line 61: The change to "urllib3>=2.6.3" loosens the dependency pin and can
harm reproducibility; revert to the exact pin "urllib3==2.6.3" in pyproject.toml
if the original exact version was required for stability, or tighten the
constraint (e.g., "urllib3>=2.6.3,<3.0" or "urllib3==2.6.3") and add a brief
comment explaining why that choice was made so future reviewers know whether the
loosening was intentional.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: a05e2cd9-2e87-4f37-a6a8-7436cbc24426
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (6)
.tekton/lightspeed-stack-pull-request.yaml.tekton/lightspeed-stack-push.yamlpyproject.tomlrequirements-build.txtrequirements.hashes.source.txtrequirements.hashes.wheel.txt
💤 Files with no reviewable changes (1)
- requirements.hashes.wheel.txt
8b2818b to
871a702
Compare
Description
This PR updates dependencies and explicitly adds dependencies for lightspeed providers.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit