LCORE-1531: Removed type ignore#1372
Conversation
WalkthroughTwo files updated to improve typing: Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/utils/types.py`:
- Around line 54-56: Define a module-level type alias (e.g., InstanceCache =
Dict[Type[Any], Any]) and replace the bare _instances: dict = {} with a
fully-typed declaration using that alias (e.g., _instances: InstanceCache = {}),
and ensure any necessary typing imports (Type, Dict, Any) are added; update the
SingletonMeta or the __call__ implementation references to use this alias to
make the singleton cache type explicit and satisfy the "complete type
annotations" guideline.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 3c328574-9cc3-4a8e-a029-98e0d81077bd
📒 Files selected for processing (2)
src/client.pysrc/utils/types.py
dec4147 to
0b231e3
Compare
Description
LCORE-1531: removed type ignore
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit