Skip to content

LCORE-1348: Regenerated schema#1388

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1348-regenerated-schema
Mar 24, 2026
Merged

LCORE-1348: Regenerated schema#1388
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1348-regenerated-schema

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Mar 24, 2026

Description

LCORE-1348: Regenerated schema

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1348

Summary by CodeRabbit

  • New Features

    • Added allow_verbose_infer configuration option
    • Added rhokp_url configuration option with environment variable override support
    • Added max_header_size configuration option for header size validation
    • Added MCP server management actions: register, list, and delete
  • Documentation

    • Updated configuration documentation with clarified examples and field descriptions

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: d49fc817-107f-4e04-84e6-9f7d6b6aaaad

📥 Commits

Reviewing files that changed from the base of the PR and between 39116c7 and 1395899.

📒 Files selected for processing (3)
  • docs/config.html
  • docs/config.json
  • docs/config.md

Walkthrough

Configuration schemas across documentation files are updated to add new fields (allow_verbose_infer, rhokp_url, max_header_size) to multiple configuration objects, update descriptions for existing fields, and extend the action enum with MCP management operations.

Changes

Cohort / File(s) Summary
Customization Schema
docs/config.html, docs/config.json, docs/config.md
Added new allow_verbose_infer boolean field (default false) across all configuration documentation formats.
OkpConfiguration Schema
docs/config.html, docs/config.json, docs/config.md
Added rhokp_url string field with environment variable override and constants fallback; updated chunk_filter_query to nullable with null default and simplified documentation referencing Solr boolean syntax.
RHIdentityConfiguration Schema
docs/config.html, docs/config.json, docs/config.md
Added max_header_size integer field (default 8192, minimum 0) to control base64-encoded x-rh-identity header size validation.
Action Enum
docs/config.json
Extended with three new MCP management actions: register_mcp_server, list_mcp_servers, delete_mcp_server.
ByokRag Documentation
docs/config.md
Removed descriptive text and YAML example explaining rag_id mapping to rag.inline/rag.tool.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'LCORE-1348: Regenerated schema' is vague and generic, using non-descriptive language that does not convey meaningful information about the specific configuration changes made. Replace with a more descriptive title that specifies the actual changes, such as 'Add MCP management actions and configuration fields for OKP and identity headers' or similar.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit b250fca into lightspeed-core:main Mar 24, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant