Skip to content

LCORE-1498: Disable annotation in root config#1391

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
asimurka:disable_rag_annotations
Mar 25, 2026
Merged

LCORE-1498: Disable annotation in root config#1391
tisnik merged 1 commit intolightspeed-core:mainfrom
asimurka:disable_rag_annotations

Conversation

@asimurka
Copy link
Copy Markdown
Contributor

@asimurka asimurka commented Mar 24, 2026

Description

This PR disables RAG annotation generation in root LLS config. It also adds section that documents configuration options for RAG annotations with linked example configs.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

  • Documentation
    • Added new section explaining RAG annotation configuration options with annotation_prompt_params settings.
    • Updated table of contents with reference to Llama Stack RAG annotations.
    • Provided configuration examples demonstrating annotation control options.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Mar 24, 2026

Walkthrough

These changes document and configure RAG annotation controls in Llama Stack. A new section in the RAG guide explains the annotation_prompt_params configuration option in vector_stores, and the project's run.yaml is updated to disable annotations via enable_annotations: false.

Changes

Cohort / File(s) Summary
RAG Annotation Documentation
docs/rag_guide.md
Added table of contents entry and new section explaining Llama Stack's annotation_prompt_params configuration for controlling whether RAG annotation instructions are injected into model prompts. Documented that this repository's configuration disables annotations and referenced examples for enabling or customizing annotation templates.
RAG Configuration
run.yaml
Added annotation_prompt_params with enable_annotations: false to vector_stores configuration to disable RAG annotation generation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and accurately summarizes the main change: disabling annotations in the root config file (run.yaml). It is concise and specific, reflecting the primary purpose of this PR.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asimurka asimurka requested a review from are-ces March 24, 2026 14:54
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@docs/rag_guide.md`:
- Line 501: The sentence "The top-level `vector_stores` block in  Llama Stack
configuration..." contains an extra space between "in" and "Llama"; edit the
paragraph in docs/rag_guide.md to remove the duplicate space so it reads "block
in Llama Stack configuration" (locate the sentence that references
`vector_stores`, `annotation_prompt_params`, and `enable_annotations` to apply
the fix).

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 66e3c839-85b0-48c4-b5d1-6c1125e5b005

📥 Commits

Reviewing files that changed from the base of the PR and between b250fca and 53a93f1.

📒 Files selected for processing (2)
  • docs/rag_guide.md
  • run.yaml

Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@are-ces
Copy link
Copy Markdown
Contributor

are-ces commented Mar 25, 2026

LGTM

@syedriko
Copy link
Copy Markdown
Contributor

/retest

@tisnik tisnik merged commit cfd7467 into lightspeed-core:main Mar 25, 2026
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants