Skip to content

LCORE-1730: Link to demos#1480

Merged
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1730-link-to-demos
Apr 9, 2026
Merged

LCORE-1730: Link to demos#1480
tisnik merged 1 commit intolightspeed-core:mainfrom
tisnik:lcore-1730-link-to-demos

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Apr 9, 2026

Description

LCORE-1730: Link to demos

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1730

Summary by CodeRabbit

Release Notes

  • Documentation
    • Added a new Demos section to the documentation with links to LCORE introduction and CodeRabbitAI demo resources.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai bot commented Apr 9, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 4775f0e4-78c0-44d5-bc24-d5c27b6a8eaf

📥 Commits

Reviewing files that changed from the base of the PR and between 7fb6bca and 008b59a.

📒 Files selected for processing (2)
  • docs/README.md
  • docs/index.md
📜 Recent review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)
  • GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
  • GitHub Check: build-pr
  • GitHub Check: E2E Tests for Lightspeed Evaluation job
  • GitHub Check: E2E: library mode / ci
  • GitHub Check: E2E: server mode / ci
🔇 Additional comments (4)
docs/index.md (2)

77-78: LGTM! Whitespace improves readability.

The additional blank lines improve visual separation between sections, making the documentation easier to scan.


88-93: Demo files are present in the repository.

Both referenced demo files exist at the expected locations:

  • docs/demos/lcore/lcore.html
  • docs/demos/lcore/coderabbit.html
docs/README.md (2)

73-74: LGTM! Consistent formatting.

The additional blank lines maintain consistency with the formatting in docs/index.md and improve section separation.


84-89: LGTM! Demos section added consistently.

The "Demos" section is formatted correctly and matches the identical addition in docs/index.md, ensuring consistency across documentation files. The demo file verification requested for docs/index.md applies here as well.


Walkthrough

Added a new "Demos" section to two documentation files linking to LCORE introduction and CodeRabbitAI resources, with whitespace adjustments around existing sections for formatting consistency.

Changes

Cohort / File(s) Summary
Documentation — Demos Section Addition
docs/README.md, docs/index.md
Added new "Demos" section containing links to LCORE introduction and CodeRabbitAI demo pages; inserted additional blank lines around Testing and Design documents sections for improved spacing.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'LCORE-1730: Link to demos' directly matches the PR's main objective of adding links to demos in documentation files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 976c059 into lightspeed-core:main Apr 9, 2026
23 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant