Skip to content

LCORE-285: Update openapi.json#153

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
onmete:update-schema
Jul 1, 2025
Merged

LCORE-285: Update openapi.json#153
tisnik merged 1 commit into
lightspeed-core:mainfrom
onmete:update-schema

Conversation

@onmete
Copy link
Copy Markdown
Contributor

@onmete onmete commented Jul 1, 2025

Description

Result of make schema.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #
  • Closes #

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@onmete
Copy link
Copy Markdown
Contributor Author

onmete commented Jul 1, 2025

@tisnik There are more changes than just mine about the readiness endpoint. There is no unit test for checking the schema. Would you like me to create one (we have in OLS)?

@onmete onmete changed the title Update openapi.json LCORE-285: Update openapi.json Jul 1, 2025
@tisnik
Copy link
Copy Markdown
Contributor

tisnik commented Jul 1, 2025

@tisnik There are more changes than just mine about the readiness endpoint. There is no unit test for checking the schema. Would you like me to create one (we have in OLS)?

@onmete nope, because the plan is to generate this file as part of GH action. So in future no manual make schema will be needed (IMHO it would be good for OLS too, but YMMV)

@onmete
Copy link
Copy Markdown
Contributor Author

onmete commented Jul 1, 2025

Part of LCORE-285 is to generate the schema, should we merge this or close it as it will be handled by the work you are mentioning?

@tisnik tisnik merged commit 883f832 into lightspeed-core:main Jul 1, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants