Skip to content

LCORE-1880: Refactor of 401 response#1544

Merged
tisnik merged 3 commits into
lightspeed-core:mainfrom
asimurka:refactor_401_response
Apr 20, 2026
Merged

LCORE-1880: Refactor of 401 response#1544
tisnik merged 3 commits into
lightspeed-core:mainfrom
asimurka:refactor_401_response

Conversation

@asimurka
Copy link
Copy Markdown
Contributor

Description

This PR adds missing examples for 401 error response to all endpoints. Inference endpoints contain also MCP auth example.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

Identify any AI code assistants used in this PR (for transparency and review context)

  • Assisted-by: N/A

Related Tickets & Documents

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 20, 2026

Warning

Rate limit exceeded

@asimurka has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 43 minutes and 22 seconds before requesting another review.

Your organization is not enrolled in usage-based pricing. Contact your admin to enable usage-based pricing to continue reviews beyond the rate limit, or try again in 43 minutes and 22 seconds.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6cde21d3-d322-4c2f-bb16-121a283e999c

📥 Commits

Reviewing files that changed from the base of the PR and between 52c5453 and a2cb0ae.

📒 Files selected for processing (26)
  • docs/openapi.json
  • src/app/endpoints/authorized.py
  • src/app/endpoints/config.py
  • src/app/endpoints/conversations_v1.py
  • src/app/endpoints/conversations_v2.py
  • src/app/endpoints/feedback.py
  • src/app/endpoints/health.py
  • src/app/endpoints/info.py
  • src/app/endpoints/mcp_auth.py
  • src/app/endpoints/mcp_servers.py
  • src/app/endpoints/metrics.py
  • src/app/endpoints/models.py
  • src/app/endpoints/prompts.py
  • src/app/endpoints/providers.py
  • src/app/endpoints/query.py
  • src/app/endpoints/rags.py
  • src/app/endpoints/responses.py
  • src/app/endpoints/rlsapi_v1.py
  • src/app/endpoints/root.py
  • src/app/endpoints/shields.py
  • src/app/endpoints/stream_interrupt.py
  • src/app/endpoints/streaming_query.py
  • src/app/endpoints/tools.py
  • src/app/endpoints/vector_stores.py
  • src/models/responses.py
  • tests/unit/models/responses/test_error_responses.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@asimurka asimurka changed the title LCORE-1880: Refactor 401 response LCORE-1880: Refactor of 401 response Apr 20, 2026
@tisnik
Copy link
Copy Markdown
Contributor

tisnik commented Apr 20, 2026

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 PR contains tests
🔒 Security concerns

No
followed all instructions

⚡ No major issues detected

@asimurka asimurka force-pushed the refactor_401_response branch from 5c4904a to 153bd93 Compare April 20, 2026 12:33
@asimurka asimurka force-pushed the refactor_401_response branch from 153bd93 to a2cb0ae Compare April 20, 2026 12:42
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tisnik
Copy link
Copy Markdown
Contributor

tisnik commented Apr 20, 2026

@asimurka LGTMed, but was it rebased? These changes in openapi spec are huge

@asimurka
Copy link
Copy Markdown
Contributor Author

Yes, it adds 401 examples that are excluded rn.

@tisnik tisnik merged commit 2b947a9 into lightspeed-core:main Apr 20, 2026
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants