Skip to content

LCORE-1592: Added link to epics and stories created#1555

Merged
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1592-added-link-to-epics-and-stories-created
Apr 21, 2026
Merged

LCORE-1592: Added link to epics and stories created#1555
tisnik merged 1 commit into
lightspeed-core:mainfrom
tisnik:lcore-1592-added-link-to-epics-and-stories-created

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented Apr 21, 2026

Description

LCORE-1592: Added link to epics and stories created

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-1592

Summary by CodeRabbit

  • Documentation
    • Updated design documentation with detailed deployment architecture planning and implementation roadmap for low-overhead server mode deployment scenarios, including container lifecycle management, configuration handling, and operational resilience strategies.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 21, 2026

Walkthrough

A design document is updated to explicitly define three epics and their corresponding user stories for low-overhead server mode deployment, replacing placeholder entries with detailed planning information for LLS (Language Lifecycle Service) distribution, container lifecycle management, and degraded-mode behavior.

Changes

Cohort / File(s) Summary
Design Documentation
docs/design/low-overhead-deployment-for-server-mode/low-overhead-deployment-for-server-mode.md
Updated "Epics created" table with three explicit epics (LCORE-1489, LCORE-1854, LCORE-1855/1856) and "Stories created" table with detailed stories covering container lifecycle, configuration management, health checks, documentation, platform support, logging, and degraded-mode functionality.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main change: adding links to epics and stories created in the documentation file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In
`@docs/design/low-overhead-deployment-for-server-mode/low-overhead-deployment-for-server-mode.md`:
- Around line 470-475: The table introduces the acronym "LLS" without defining
it; update the table rows (e.g., entries for LCORE-1489, LCORE-1854, LCORE-1855,
LCORE-1856) to expand "LLS" on first use to "LLS (Llama Stack)" or replace "LLS"
with "Llama Stack" so the acronym is defined/explicit in the table; apply the
same change to the other affected table rows around lines 481–502 to ensure
consistency.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 1cbf10db-ff81-491d-b5dd-0b00e08d7fcb

📥 Commits

Reviewing files that changed from the base of the PR and between ac428f3 and c0d2d25.

📒 Files selected for processing (1)
  • docs/design/low-overhead-deployment-for-server-mode/low-overhead-deployment-for-server-mode.md
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
  • GitHub Check: Pyright
  • GitHub Check: unit_tests (3.13)
  • GitHub Check: Pylinter
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: radon
  • GitHub Check: build-pr
  • GitHub Check: E2E: library mode / ci / group 1
  • GitHub Check: E2E: server mode / ci / group 3
  • GitHub Check: E2E: server mode / ci / group 1
  • GitHub Check: E2E: library mode / ci / group 2
  • GitHub Check: E2E: server mode / ci / group 2
  • GitHub Check: E2E: library mode / ci / group 3
  • GitHub Check: E2E Tests for Lightspeed Evaluation job

Comment on lines +470 to +475
| Epic | Description | Link |
|------------|-------------------------------------------------------------------|------------------------------------------------|
| LCORE-1489 | Build custom LLS distribution for LCORE | https://redhat.atlassian.net/browse/LCORE-1489 |
| LCORE-1854 | Ability to start and teardown LLS from container image | https://redhat.atlassian.net/browse/LCORE-1854 |
| LCORE-1855 | Ability to start and teardown LLS installed locally | https://redhat.atlassian.net/browse/LCORE-1855 |
| LCORE-1856 | Ability for LCORE to run in degraded mode when LLS is not running | https://redhat.atlassian.net/browse/LCORE-1856 |
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Define LLS on first use in these tables (or switch to Llama Stack).

These new entries introduce LLS, but the document body primarily uses Llama Stack. Please expand the acronym on first use in the changed tables to avoid ambiguity for readers scanning only these sections.

Also applies to: 481-502

🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In
`@docs/design/low-overhead-deployment-for-server-mode/low-overhead-deployment-for-server-mode.md`
around lines 470 - 475, The table introduces the acronym "LLS" without defining
it; update the table rows (e.g., entries for LCORE-1489, LCORE-1854, LCORE-1855,
LCORE-1856) to expand "LLS" on first use to "LLS (Llama Stack)" or replace "LLS"
with "Llama Stack" so the acronym is defined/explicit in the table; apply the
same change to the other affected table rows around lines 481–502 to ensure
consistency.

@tisnik tisnik merged commit 832e911 into lightspeed-core:main Apr 21, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant