Skip to content

Enable RAG tool when a vector DB is available#166

Merged
tisnik merged 2 commits into
mainfrom
TamiTakamiya/enable-rag-tool-when-vector-db-is-available
Jul 2, 2025
Merged

Enable RAG tool when a vector DB is available#166
tisnik merged 2 commits into
mainfrom
TamiTakamiya/enable-rag-tool-when-vector-db-is-available

Conversation

@TamiTakamiya
Copy link
Copy Markdown
Contributor

@TamiTakamiya TamiTakamiya commented Jul 2, 2025

Description

Enable RAG tool (builtin::rag/knowledge_search) when one or more vector DBs are defined on llama-stack.

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue # n/a
  • Closes # n/a

Checklist before requesting a review

  • I have performed a self-review of my code.
  • PR has passed all pre-merge test jobs.
  • If it is a core feature, I have added thorough tests.

Testing

  • Please provide detailed steps to perform tests related to this code change.
  • How were the fix/results from this change verified? Please provide relevant screenshots or results.

@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/enable-rag-tool-when-vector-db-is-available branch 7 times, most recently from 6c1d649 to aa39b47 Compare July 2, 2025 00:58
@TamiTakamiya TamiTakamiya force-pushed the TamiTakamiya/enable-rag-tool-when-vector-db-is-available branch from aa39b47 to 3596199 Compare July 2, 2025 01:15
@TamiTakamiya TamiTakamiya marked this pull request as ready for review July 2, 2025 02:02
@TamiTakamiya TamiTakamiya changed the title [WIP] Enable RAG tool when a vector DB is available Enable RAG tool when a vector DB is available Jul 2, 2025
Copy link
Copy Markdown
Contributor

@manstis manstis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@tisnik we need this.

Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks ok, just one nitpick - we can use list as type hint, that does not have to be imported

Comment thread src/app/endpoints/query.py Outdated
Comment thread src/app/endpoints/query.py Outdated
Copy link
Copy Markdown
Contributor

@umago umago left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tami! Code-wise it does LGTM except the nit that Pavel already pointed out.

Thanks for working on this, we very much need it!

Comment thread src/app/endpoints/query.py Outdated
Copy link
Copy Markdown
Contributor

@tisnik tisnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks perfect, TYVM

@tisnik tisnik merged commit a5e9982 into main Jul 2, 2025
31 checks passed
@TamiTakamiya TamiTakamiya deleted the TamiTakamiya/enable-rag-tool-when-vector-db-is-available branch July 2, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants