Enable RAG tool when a vector DB is available#166
Merged
tisnik merged 2 commits intoJul 2, 2025
Conversation
6c1d649 to
aa39b47
Compare
aa39b47 to
3596199
Compare
tisnik
requested changes
Jul 2, 2025
Contributor
tisnik
left a comment
There was a problem hiding this comment.
it looks ok, just one nitpick - we can use list as type hint, that does not have to be imported
umago
reviewed
Jul 2, 2025
Contributor
umago
left a comment
There was a problem hiding this comment.
Thanks Tami! Code-wise it does LGTM except the nit that Pavel already pointed out.
Thanks for working on this, we very much need it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enable RAG tool (
builtin::rag/knowledge_search) when one or more vector DBs are defined on llama-stack.Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing