LCORE-1983: Added e2e scenario for OpenTelemetry#1683
Conversation
|
Warning Rate limit exceeded
To keep reviews running without waiting, you can enable usage-based add-on for your organization. This allows additional reviews beyond the hourly cap. Account admins can enable it under billing. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdds a new end-to-end Gherkin feature that validates OpenTelemetry export/OTLP ingestion for an authorized ChangesOpenTelemetry E2E Test Suite
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/e2e/features/opentelemetry.feature`:
- Line 9: The feature contains a hardcoded JWT in the step "And I set the
Authorization header to Bearer ..."; remove that literal token and change the
step to use an env/fixture-backed placeholder (e.g., reference a variable like
ACCESS_TOKEN or a test fixture token) so the header is set from process.env or
the test fixture at runtime; update the step implementation that reads the
header (the step definition handling "I set the Authorization header to Bearer")
to pull the token from the environment/fixture when a placeholder is provided.
- Around line 24-25: Replace the fixed "safety_identifier" string with a
per-scenario unique value (e.g., a UUID or timestamp) generated in the scenario
setup (Before/Background) and injected into the payload under
"safety_identifier"; then use that same generated value in both the export
assertion and the collector assertion so each run checks the exact marker it
emitted (reference the "safety_identifier" field and the scenario's
export/collector assertions to locate where to set and compare the value).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 735a5c8b-672f-43f0-a85e-ac4808de0790
📒 Files selected for processing (1)
tests/e2e/features/opentelemetry.feature
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (11)
- GitHub Check: Pyright
- GitHub Check: radon
- GitHub Check: spectral
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: E2E Tests for Lightspeed Evaluation job
🧰 Additional context used
📓 Path-based instructions (1)
tests/e2e/**/*.{feature,py}
📄 CodeRabbit inference engine (AGENTS.md)
Use behave (BDD) framework for end-to-end testing with Gherkin feature files
Files:
tests/e2e/features/opentelemetry.feature
asimurka
force-pushed
the
otel_e2e_tests
branch
2 times, most recently
from
b20882d to
820055a
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@tests/e2e/features/opentelemetry.feature`:
- Line 1: The feature is marked with the `@skip` tag which prevents the new
OpenTelemetry e2e scenario from running; edit the feature tag line that
currently contains "@e2e_group_1 `@Authorized` `@skip`" and remove the "@skip" token
so the feature will be executed in CI while leaving the other tags intact.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 1f0e29dc-83c0-46c5-a59c-370eaa2569da
📒 Files selected for processing (2)
tests/e2e/features/opentelemetry.featuretests/e2e/test_list.txt
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (16)
- GitHub Check: mypy
- GitHub Check: spectral
- GitHub Check: Pylinter
- GitHub Check: build-pr
- GitHub Check: Pyright
- GitHub Check: integration_tests (3.12)
- GitHub Check: unit_tests (3.12)
- GitHub Check: unit_tests (3.13)
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E Tests for Lightspeed Evaluation job
🧰 Additional context used
📓 Path-based instructions (2)
tests/e2e/test_list.txt
📄 CodeRabbit inference engine (AGENTS.md)
End-to-end test list maintained in
tests/e2e/test_list.txt
Files:
tests/e2e/test_list.txt
tests/e2e/**/*.{feature,py}
📄 CodeRabbit inference engine (AGENTS.md)
Use behave (BDD) framework for end-to-end testing with Gherkin feature files
Files:
tests/e2e/features/opentelemetry.feature
🔇 Additional comments (2)
tests/e2e/features/opentelemetry.feature (2)
9-9: Hardcoded bearer token is still committed at Line 9.Please replace the literal JWT with an env/fixture-backed placeholder so credentials are sourced at runtime, not from versioned test files.
24-25: Static telemetry marker at Line 24 can cause cross-run false positives.Use a per-scenario unique marker and assert that exact value at Lines 28-29.
Also applies to: 28-29
2 participants
Description
Adds an e2e test scenario for OpenTelemetry. The scenario tests whether Otel events are exported and successfully received by configured Otel service. The remaining functionality will be tested by integration tests.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit