LCORE-1964: Work files used by Konflux infrastructure pollute the top level in LCORE repositories#1727
Conversation
|
/ok-to-test |
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (14)
WalkthroughThis PR consolidates build artifacts into a ChangesKonflux directory consolidation
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
syedriko
force-pushed
the
syedriko-lcore-1964
branch
from
bb7a9b1 to
610452c
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.tekton/lightspeed-stack-pull-request.yaml:
- Line 53: The PR pipeline config was updated to move dependency inputs under
".konflux" but the build-args-file reference still points to the repo root file;
update the build-args-file entry in .tekton/lightspeed-stack-pull-request.yaml
to reference the relocated file under ".konflux" (e.g., change the value of
build-args-file to ".konflux/build-args-konflux.conf") so the pipeline matches
the new .konflux layout.
In `@scripts/konflux_requirements.sh`:
- Around line 9-15: The script sets KONFLUX_DIR and several target files
(RAW_REQ_FILE, SOURCE_FILE, WHEEL_FILE, SOURCE_HASH_FILE, WHEEL_HASH_FILE,
BUILD_FILE) but never creates the .konflux directory; add a step immediately
after KONFLUX_DIR is defined to create the directory (e.g., run mkdir -p
"${KONFLUX_DIR}") and fail early on error so subsequent redirects to
"${KONFLUX_DIR}/..." succeed; ensure this creation happens before any writes to
SOURCE_FILE, WHEEL_FILE, etc., and consider using a conditional check or set -e
to surface failures.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: bcccaf8f-ab3b-414b-b07d-e474d12f2640
📒 Files selected for processing (13)
.konflux/artifacts.lock.yaml.konflux/build-args-konflux.conf.konflux/redhat.repo.konflux/requirements-build.txt.konflux/requirements.hashes.source.txt.konflux/requirements.hashes.wheel.txt.konflux/requirements.hermetic.txt.konflux/requirements.overrides.txt.konflux/rpms.in.yaml.konflux/rpms.lock.yaml.tekton/lightspeed-stack-pull-request.yaml.tekton/lightspeed-stack-push.yamlscripts/konflux_requirements.sh
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (7)
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: build-pr
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 3
🔇 Additional comments (1)
.tekton/lightspeed-stack-push.yaml (1)
37-37: LGTM!Also applies to: 41-41, 45-45, 65-65
syedriko
force-pushed
the
syedriko-lcore-1964
branch
from
610452c to
fe9c403
Compare
|
/ok-to-test |
… level in LCORE repositories
syedriko
force-pushed
the
syedriko-lcore-1964
branch
from
fe9c403 to
98a3594
Compare
tisnik
left a comment
tisnik
left a comment
There was a problem hiding this comment.
LGTM, but let's wait for CI to finish
2 participants
Description
Work files used by Konflux infrastructure pollute the top level in LCORE repositories. It confuses developers.
Moved Konflux-related files into the .konflux directory.
Type of change
Tools used to create PR
Identify any AI code assistants used in this PR (for transparency and review context)
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit