Skip to content

LCORE-2318: Options to wait for Llama Stack#1780

Merged
tisnik merged 3 commits into
lightspeed-core:mainfrom
tisnik:lcore-2318-options-to-wait-for-llama-stack
May 24, 2026
Merged

LCORE-2318: Options to wait for Llama Stack#1780
tisnik merged 3 commits into
lightspeed-core:mainfrom
tisnik:lcore-2318-options-to-wait-for-llama-stack

Conversation

@tisnik
Copy link
Copy Markdown
Contributor

@tisnik tisnik commented May 24, 2026

Description

LCORE-2318: Options to wait for Llama Stack

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement
  • Benchmarks improvement

Tools used to create PR

  • Assisted-by: N/A
  • Generated by: N/A

Related Tickets & Documents

  • Related Issue #LCORE-2318

Summary by CodeRabbit

  • New Features
    • Added configurable startup retry settings to support flexible deployment scenarios. Users can now specify the maximum number of retry attempts (default: 5) and the delay between consecutive retries in seconds (default: 2). These configuration options provide greater control over system behavior during initialization across various operational environments.

Review Change Stack

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 24, 2026

Warning

Review limit reached

@tisnik, we couldn't start this review because you've used your available PR reviews for now.

Your plan currently allows 1 review/hour. Refill in 40 minutes and 16 seconds.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more review capacity refills, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than trial, open-source, and free plans. In all cases, review capacity refills continuously over time.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 2aa6dff6-e2b5-434c-8a39-12782f3415b0

📥 Commits

Reviewing files that changed from the base of the PR and between 2a6c5a9 and 73e992b.

📒 Files selected for processing (6)
  • docs/config.html
  • docs/config.json
  • docs/config.md
  • docs/openapi.json
  • tests/unit/models/config/test_dump_configuration.py
  • tests/unit/models/config/test_llama_stack_configuration.py

Walkthrough

PR adds startup retry configuration by introducing DEFAULT_MAX_RETRIES (5) and DEFAULT_RETRY_DELAY (2) constants in src/constants.py, then adds corresponding max_retries and retry_delay fields to LlamaStackConfiguration in src/models/config.py to control Llama Stack readiness verification during initialization.

Changes

Startup retry configuration

Layer / File(s) Summary
Startup retry constants
src/constants.py
DEFAULT_MAX_RETRIES and DEFAULT_RETRY_DELAY constants are defined to govern retry timing for Llama Stack readiness during sidecar startup.
LlamaStackConfiguration retry fields
src/models/config.py
max_retries and retry_delay fields are added to LlamaStackConfiguration as PositiveInt values, defaulting to the new constants and controlling fixed-delay retry behavior.

🎯 2 (Simple) | ⏱️ ~8 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change—adding configurable options (max_retries and retry_delay) to wait for Llama Stack startup, which is the core feature introduced across constants.py and config.py.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
✨ Simplify code
  • Create PR with simplified code

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 496eff7 into lightspeed-core:main May 24, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant