LCORE-2324: Fixed Konflux script#1789
Merged
tisnik merged 1 commit intoMay 25, 2026
Merged
Conversation
Contributor
WalkthroughThe Konflux build script no longer enforces a specific pinned version of maturin. A single ChangesMaturin Version Constraint Removal
🎯 1 (Trivial) | ⏱️ ~3 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/konflux_requirements.sh`:
- Around line 82-84: Unclear temporary removal of the maturin pin needs
resolution: either re-enable the sed that pins maturin to 1.10.2 (undo the
commented-out line using the sed operation that updates "$BUILD_FILE") or remove
the “LCORE-2324: commented out (temporarily?)” marker and replace it with a
concise justification explaining why the pin was removed (e.g., maturin 1.10.2
was deprecated/incompatible/unavailable and caused X bug). After changing the
script, run the build-deps generation step (uv run pybuild-deps compile) and
verify the produced requirements-build.txt contains the expected maturin version
(or document that it deliberately does not and why), and update the comment to
reference LCORE-2324 with the exact rationale and test evidence.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Pro
Run ID: 84af9019-37af-40c8-9070-2d39e65908b9
📒 Files selected for processing (1)
scripts/konflux_requirements.sh
📜 Review details
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (13)
- GitHub Check: unit_tests (3.12)
- GitHub Check: unit_tests (3.13)
- GitHub Check: build-pr
- GitHub Check: spectral
- GitHub Check: Pylinter
- GitHub Check: Konflux kflux-prd-rh02 / lightspeed-stack-on-pull-request
- GitHub Check: E2E: library mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 2
- GitHub Check: E2E: server mode / ci / group 1
- GitHub Check: E2E: server mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 3
- GitHub Check: E2E: library mode / ci / group 2
- GitHub Check: E2E Tests for Lightspeed Evaluation job
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2026-05-12T15:14:34.788Z
Learnt from: syedriko
Repo: lightspeed-core/lightspeed-stack PR: 1727
File: scripts/konflux_requirements.sh:9-15
Timestamp: 2026-05-12T15:14:34.788Z
Learning: In this repo, the `.konflux/` directory is committed/tracked and is guaranteed to exist in a fresh clone. Therefore, shell scripts that write output under `.konflux/` (e.g., create files like `.konflux/<...>`) should not waste effort by calling `mkdir -p .konflux` first. Only add directory-creation logic if the script may run in an environment/repo state where `.konflux/` might not be present.
Applied to files:
scripts/konflux_requirements.sh
Comment on lines
82
to
+84
| # pin maturin to the version available in the Red Hat registry | ||
| sed -i 's/maturin==[0-9.]*/maturin==1.10.2/' "$BUILD_FILE" | ||
| # LCORE-2324: commented out (temporarily?) | ||
| # sed -i 's/maturin==[0-9.]*/maturin==1.10.2/' "$BUILD_FILE" |
Contributor
There was a problem hiding this comment.
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
# Description: Determine the maturin version that pybuild-deps will resolve
# Temporarily restore the script to generate BUILD_FILE without the pin
cd .konflux
uv run pybuild-deps compile --output-file=/tmp/test-build.txt requirements.source.txt 2>/dev/null || echo "pybuild-deps failed"
# Extract maturin version
echo "Resolved maturin version:"
rg -n 'maturin==' /tmp/test-build.txt || echo "No maturin found in generated file"
# Check if that version is mentioned in current requirements-build.txt
echo -e "\nCurrent pinned version in requirements-build.txt:"
rg -n 'maturin==' .konflux/requirements-build.txtRepository: lightspeed-core/lightspeed-stack
Length of output: 358
Restore/justify deterministic maturin pin (and clarify intent for LCORE-2324)
# LCORE-2324: commented out (temporarily?)leaves unclear whether thematurin==1.10.2pin was intentionally removed permanently; either re-enable the pin/constraint or remove the uncertainty marker with the rationale.- PR calls it a “bug fix” but doesn’t state what bug was fixed by the
1.10.2pin (deprecated/unavailable/incompatible?); include that explanation. - Provide evidence that the build-time dependency generation used by Tekton (i.e.,
requirements-build.txtproduced fromuv run pybuild-deps compile) still resolves to the expectedmaturinversion and has been tested without the pin (the suggested check didn’t producerequirements-build.txtin the current environment).
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/konflux_requirements.sh` around lines 82 - 84, Unclear temporary
removal of the maturin pin needs resolution: either re-enable the sed that pins
maturin to 1.10.2 (undo the commented-out line using the sed operation that
updates "$BUILD_FILE") or remove the “LCORE-2324: commented out (temporarily?)”
marker and replace it with a concise justification explaining why the pin was
removed (e.g., maturin 1.10.2 was deprecated/incompatible/unavailable and caused
X bug). After changing the script, run the build-deps generation step (uv run
pybuild-deps compile) and verify the produced requirements-build.txt contains
the expected maturin version (or document that it deliberately does not and
why), and update the comment to reference LCORE-2324 with the exact rationale
and test evidence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
LCORE-2324: Fixed Konflux script
Type of change
Tools used to create PR
Related Tickets & Documents
Summary by CodeRabbit