Add work-around for tool_calls with granite models and /query endpoint.

[manstis]

Description

Further to #211 my colleague @ldjebran pointed out I'd missed the /query endpoint.

This PR fills that gap.

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Related Tickets & Documents

• Related Issue # N/A
• Closes # https://issues.redhat.com/browse/AAP-48374

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

• Please provide detailed steps to perform tests related to this code change.
• How were the fix/results from this change verified? Please provide relevant screenshots or results.

Summary by CodeRabbit

• Bug Fixes

  • Improved internal handling for agent creation to enhance compatibility with different models.

• Tests

  • Updated unit tests to reflect changes in agent initialization and ensure continued reliability.

[coderabbitai]

Walkthrough

The changes introduce the use of GraniteToolParser.get_parser(model_id) as a new tool_parser argument when constructing an Agent instance within the get_agent function. Corresponding unit tests are updated to include this argument in their mocks, ensuring consistency with the updated function implementation.

Changes

File(s)	Change Summary
src/app/endpoints/query.py	Imports GraniteToolParser and adds tool_parser=GraniteToolParser.get_parser(model_id) to Agent.
tests/unit/app/endpoints/test_query.py	Updates all Agent constructor mocks to include tool_parser=None argument.

Possibly related PRs

• Add work-around for tool_calls with granite models. #211: Both PRs modify the get_agent function to pass a tool_parser argument derived from GraniteToolParser.get_parser(model_id) when constructing an agent, directly relating their changes at the code level.

Suggested reviewers

• umago
• tisnik

Poem

A parser hops in, with granite in name,
Now agents are smarter, no two are the same.
The tests all align, with arguments new,
As rabbits, we cheer for this clever debut!
🐇✨

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d501148 and 4ad2636.

📒 Files selected for processing (2)

• src/app/endpoints/query.py (2 hunks)
• tests/unit/app/endpoints/test_query.py (5 hunks)

🧰 Additional context used

🧬 Code Graph Analysis (1)

src/app/endpoints/query.py (1)

src/utils/types.py (2)

• GraniteToolParser (23-37)
• get_parser (33-37)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

• GitHub Check: build-pr

🔇 Additional comments (3)

src/app/endpoints/query.py (2)

34-34: LGTM: Clean import addition.

The import of GraniteToolParser is correctly placed and necessary for the granite model workaround implementation.

---

87-87: LGTM: Correct implementation of granite model workaround.

The tool_parser parameter correctly uses GraniteToolParser.get_parser(model_id) which will return a granite-specific tool parser for granite models and None for others. This implementation handles the edge case of None model_id safely and integrates cleanly with the existing code.

tests/unit/app/endpoints/test_query.py (1)

916-916: LGTM: Comprehensive test updates for new parameter.

All test cases have been correctly updated to include the tool_parser=None parameter in the mocked Agent constructor calls. This ensures the tests remain compatible with the updated function signature while maintaining their original test coverage.

Also applies to: 967-967, 1018-1018, 1070-1070, 1116-1116

✨ Finishing Touches

• 📝 Generate Docstrings

---

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[ldjebran]

LGTM , many thanks @manstis