Skip to content

Add work-around for tool_calls with granite models and /query endpoint. #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 10, 2025
Merged

Add work-around for tool_calls with granite models and /query endpoint. #219

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/app/endpoints/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,7 @@
from utils.endpoints import check_configuration_loaded, get_system_prompt
from utils.mcp_headers import mcp_headers_dependency
from utils.suid import get_suid
from utils.types import GraniteToolParser

logger = logging.getLogger("app.endpoints.handlers")
router = APIRouter(tags=["query"])
Expand Down Expand Up @@ -83,6 +84,7 @@ def get_agent(
model=model_id,
instructions=system_prompt,
input_shields=available_shields if available_shields else [],
tool_parser=GraniteToolParser.get_parser(model_id),
enable_session_persistence=True,
)
conversation_id = agent.create_session(get_suid())
Expand Down
5 changes: 5 additions & 0 deletions tests/unit/app/endpoints/test_query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -913,6 +913,7 @@ def test_get_agent_cache_miss_with_conversation_id(
model="test_model",
instructions="test_prompt",
input_shields=["shield1"],
tool_parser=None,
enable_session_persistence=True,
)

Expand Down Expand Up @@ -963,6 +964,7 @@ def test_get_agent_no_conversation_id(setup_configuration, prepare_agent_mocks,
model="test_model",
instructions="test_prompt",
input_shields=["shield1"],
tool_parser=None,
enable_session_persistence=True,
)

Expand Down Expand Up @@ -1013,6 +1015,7 @@ def test_get_agent_empty_shields(setup_configuration, prepare_agent_mocks, mocke
model="test_model",
instructions="test_prompt",
input_shields=[],
tool_parser=None,
enable_session_persistence=True,
)

Expand Down Expand Up @@ -1064,6 +1067,7 @@ def test_get_agent_multiple_mcp_servers(
model="test_model",
instructions="test_prompt",
input_shields=["shield1", "shield2"],
tool_parser=None,
enable_session_persistence=True,
)

Expand Down Expand Up @@ -1109,5 +1113,6 @@ def test_get_agent_session_persistence_enabled(
model="test_model",
instructions="test_prompt",
input_shields=["shield1"],
tool_parser=None,
enable_session_persistence=True,
)