Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Jul 11, 2025

Description

LCORE-240: build dependencies

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-240

Summary by CodeRabbit

  • Chores
    • Added a new dependency group for build tools, including updated versions of build and twine.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 11, 2025

Walkthrough

A new dependency group named build was introduced in the pyproject.toml file. This group specifies the packages build (version 1.2.2.post1 or higher) and twine (version 5.1.1 or higher) for use in the build process. No other configurations were altered.

Changes

File Change Summary
pyproject.toml Added a build dependency group with build>=1.2.2.post1 and twine>=5.1.1 to dependency-groups

Poem

In the garden of code, a new group did sprout,
For building and twining, there’s no longer doubt.
With build and with twine, our package will shine,
In the pyproject patch, all the dependencies align.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9640295 and 9fcd408.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: unit_tests (3.12)
  • GitHub Check: build-pr
🔇 Additional comments (2)
pyproject.toml (2)

53-56: Re-evaluate the choice of [dependency-groups].build vs. [build-system].requires

pdm build already installs the packages listed under [build-system].requires.
Duplicating build-time requirements in a separate optional group:

  1. Requires a manual pdm install -G build step that CI/CD might forget.
  2. Drifts out of sync with [build-system] over time.
  3. Adds cognitive overhead for contributors (“which group do I use?”).

Unless you have a concrete need to install build/twine without the backend (e.g. Docker multi-stage publish image), consider either:

-[dependency-groups]
-dev = [...]
-build = [
-    "build>=1.2.2.post1",
-    "twine>=5.1.1",
-]
+[build-system]
+requires = [
+    "pdm-backend",
+    "build>=1.2.2.post1",
+    "twine>=5.1.1",
+]

or move the two packages into the existing dev group.

This keeps a single source of truth and avoids accidental mismatches.
[ suggest_essential_refactor ]


55-55: Pin to the first secure patch, not just a lower bound

build>=1.2.2.post1 pulls the latest 1.x or even a future 2.x in reproducible
environments (pdm lock --non-interactive), potentially introducing breaking
changes. Unless you have an explicit policy of floating dependencies, lock to the
exact version you’ve validated:

-    "build>=1.2.2.post1",
+    "build==1.2.2.post1",

…same for twine.

This improves determinism for local developers and CI images.
[ suggest_optional_refactor ]


🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tisnik tisnik merged commit b69c20b into lightspeed-core:main Jul 11, 2025
17 checks passed
@coderabbitai coderabbitai bot mentioned this pull request Aug 19, 2025
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant