Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Aug 19, 2025

Description

LCORE-563: unify Twine requirements

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-563

Summary by CodeRabbit

  • Chores
    • Updated build/publishing dependency to a newer major version in the project configuration.
    • No user-facing functionality or UI changes.
    • Enhances release pipeline stability and compatibility across environments.
    • Installations and updates remain unaffected for end-users.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 19, 2025

Walkthrough

Bumps the Twine build dependency in pyproject.toml from twine>=5.1.1 to twine>=6.1.0. No other files or settings are changed.

Changes

Cohort / File(s) Summary
Build dependency version bump
pyproject.toml
Updated Twine requirement from >=5.1.1 to >=6.1.0 in the top-level build list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A rabbit taps the version tree,
Twine hops up to six point three—
Er, one! the ivy’s neatly spun,
Build threads gleam in morning sun. 🌿🧵
Small nudge, tidy run,
Packages packed—now off we run! 🐇✨

Tip

🔌 Remote MCP (Model Context Protocol) integration is now available!

Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
pyproject.toml (1)

141-144: Consider adding an upper bound to avoid unexpected breakage from Twine 7

To keep CI/release pipelines stable against future major changes, consider constraining Twine to the current major:

     "build>=1.2.2.post1",
-    "twine>=6.1.0",
+    "twine>=6.1.0,<7",
 ]

Additionally, mirror the same constraint in the dev group to maintain a single, unified spec across groups (outside the changed hunk):

# in [dependency-groups].dev
"twine>=6.1.0,<7",
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between b0a737b and 0f66d10.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests
🔇 Additional comments (2)
pyproject.toml (2)

141-144: Bump looks good and aligns build/dev groups

Unifying on twine>=6.1.0 in the build group matches the dev group and keeps tooling consistent. No impact on runtime since Twine is a dev/build tool.


141-144: No local Twine invocations found – verify your external CI/release pipelines for Twine 6.x compatibility

I ran a repo-wide search for twine (shell scripts, workflows, Makefiles, Python files, etc.) and found only the version pin in pyproject.toml. If your publish/release process lives outside this repo (e.g. in hosted CI scripts or GitHub Actions you haven’t committed here), please double-check that any twine commands:

  • Don’t use deprecated flags (e.g. --skip-existing, --non-interactive, explicit --repository in place of env-based config)
  • Handle authentication correctly (env vars vs. username/password flags)
  • Still honor repository config handling as expected under Twine 6.x

Let me know if you need help updating any CI steps.

@tisnik tisnik merged commit 601339b into lightspeed-core:main Aug 19, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant