-
Notifications
You must be signed in to change notification settings - Fork 54
LCORE-563: unify Twine requirements #421
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-563: unify Twine requirements #421
Conversation
WalkthroughBumps the Twine build dependency in pyproject.toml from twine>=5.1.1 to twine>=6.1.0. No other files or settings are changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
pyproject.toml (1)
141-144: Consider adding an upper bound to avoid unexpected breakage from Twine 7To keep CI/release pipelines stable against future major changes, consider constraining Twine to the current major:
"build>=1.2.2.post1", - "twine>=6.1.0", + "twine>=6.1.0,<7", ]Additionally, mirror the same constraint in the dev group to maintain a single, unified spec across groups (outside the changed hunk):
# in [dependency-groups].dev "twine>=6.1.0,<7",
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
🔇 Additional comments (2)
pyproject.toml (2)
141-144: Bump looks good and aligns build/dev groupsUnifying on twine>=6.1.0 in the build group matches the dev group and keeps tooling consistent. No impact on runtime since Twine is a dev/build tool.
141-144: No local Twine invocations found – verify your external CI/release pipelines for Twine 6.x compatibilityI ran a repo-wide search for
twine(shell scripts, workflows, Makefiles, Python files, etc.) and found only the version pin inpyproject.toml. If your publish/release process lives outside this repo (e.g. in hosted CI scripts or GitHub Actions you haven’t committed here), please double-check that anytwinecommands:
- Don’t use deprecated flags (e.g.
--skip-existing,--non-interactive, explicit--repositoryin place of env-based config)- Handle authentication correctly (env vars vs. username/password flags)
- Still honor repository config handling as expected under Twine 6.x
Let me know if you need help updating any CI steps.
Description
LCORE-563: unify Twine requirements
Type of change
Related Tickets & Documents
Summary by CodeRabbit