-
Notifications
You must be signed in to change notification settings - Fork 54
LCORE-448: Bump-up to version 0.1.2 #326
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe version number was incremented from "0.1.1" to "0.1.2" in the OpenAPI specification, Python version file, README badge, and dependency version in documentation. No changes were made to logic, API paths, schemas, or exported entities. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
Note ⚡️ Unit Test Generation is now available in beta!Learn more here, or try it out under "Finishing Touches" below. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (2)
docs/openapi.json (2)
10-10: Spec version updated — consider generating this field fromsrc/version.pyThe manual duplication of the version string (
"0.1.2") invites future mismatch between code and spec. Long-term, pipe the value in at build time (e.g.,sed,jinja2, orpydantic-settings) so there’s a single source of truth.
1771-1771: Missing trailing newline (minor)The file now ends without a newline; some linters flag this. Add one if your tooling enforces POSIX-style newlines.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
docs/openapi.json(2 hunks)src/version.py(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: e2e_tests
| # source = "file" | ||
| # path = "src/version.py" | ||
| __version__ = "0.1.1" | ||
| __version__ = "0.1.2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Version bump looks good – please confirm no stale “0.1.1” strings remain
👍 __version__ now reads 0.1.2. To avoid subtle drift (e.g., README badges, Helm charts, CI manifests), run a quick search and fix any leftovers.
🏁 Script executed:
#!/usr/bin/env bash
# Find hard-coded occurrences of the old version.
rg --colors=never -n '"0\.1\.1"' || trueLength of output: 143
The rg invocation is using an invalid --colors=never flag. Let’s re-run the search with the correct --color=never option (and fall back to grep if needed):
🏁 Script executed:
#!/usr/bin/env bash
# Corrected search for hard-coded occurrences of the old version "0.1.1"
echo "Searching with ripgrep..."
rg --color=never -n '0\.1\.1' || true
echo "Fallback search with grep..."
grep -R "0.1.1" -n . || trueLength of output: 65963
Update remaining hard-coded “0.1.1” references to “0.1.2”
We found two leftover occurrences of the prior release tag that need bumping:
• README.md (line 9): update badge link
• docs/getting_started.md (line 666): update example dependency spec
Suggested diffs:
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@
[](https://github.com/lightspeed-core/lightspeed-stack/releases/tag/0.1.1)− https://github.com/lightspeed-core/lightspeed-stack/releases/tag/0.1.1
--- a/docs/getting_started.md
+++ b/docs/getting_started.md
@@ -663,7 +663,7 @@
To install the local build:
```shell
-~ lightspeed-stack==0.1.1 (from file:///tmp/ramdisk/lightspeed-stack)
+~ lightspeed-stack==0.1.2 (from file:///tmp/ramdisk/lightspeed-stack)
After applying these, rerun `rg -n '0\.1\.1'` to confirm no stale references remain.
<details>
<summary>🤖 Prompt for AI Agents</summary>
In src/version.py at line 12, the version string is correctly updated to
"0.1.2". Now update the remaining hard-coded "0.1.1" references in README.md at
line 9 by changing the release tag URL to "0.1.2" and in docs/getting_started.md
at line 666 by updating the example dependency specification from
"lightspeed-stack==0.1.1" to "lightspeed-stack==0.1.2". After these changes, run
a search for "0.1.1" to ensure no stale references remain.
</details>
<!-- fingerprinting:phantom:triton:cougar -->
<!-- This is an auto-generated comment by CodeRabbit -->
fd3cef9 to
23461ed
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
README.md (1)
9-9: Consider using a “latest” release link to avoid future manual bumps
Hard-coding the tag (/releases/tag/0.1.2) means README must be edited for every version bump. Pointing to/releases/latest(or omitting the explicit tag) keeps the badge link evergreen and removes this recurrent maintenance step.-[](https://github.com/lightspeed-core/lightspeed-stack/releases/tag/0.1.2) +[](https://github.com/lightspeed-core/lightspeed-stack/releases/latest)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
README.md(1 hunks)docs/getting_started.md(1 hunks)docs/openapi.json(2 hunks)src/version.py(1 hunks)
✅ Files skipped from review due to trivial changes (2)
- docs/getting_started.md
- docs/openapi.json
🚧 Files skipped from review as they are similar to previous changes (1)
- src/version.py
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
README.md
9-9: Unordered list indentation
Expected: 2; Actual: 4
(MD007, ul-indent)
Description
LCORE-448: Bump-up to version 0.1.2
Type of change
Related Tickets & Documents
Summary by CodeRabbit