-
Notifications
You must be signed in to change notification settings - Fork 54
LCORE-336: update dependencies excluding OpenAI #370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-336: update dependencies excluding OpenAI #370
Conversation
WalkthroughThe Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Note 🔌 MCP (Model Context Protocol) integration is now available in Early Access!Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context. ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
4966f9c to
8b0f9dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
| "starlette>=0.47.1", | ||
| "aiohttp>=3.12.14", | ||
| "authlib>=1.6.0", | ||
| "openai==1.99.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Remove OpenAI addition; it contradicts PR scope (LCORE-336).
PR explicitly says “update dependencies excluding OpenAI,” but this adds a new runtime dep openai==1.99.1. Please drop this change from this PR or move it to a separate, explicitly scoped PR. If OpenAI is needed, consider placing it in a non-core dependency group (e.g., an optional group) rather than the core runtime deps.
Apply this diff to revert for this PR:
- "openai==1.99.1",Optionally, if needed in a separate PR, prefer an optional group:
+[dependency-groups]
+ai-providers = [
+ "openai==1.99.1",
+]To ensure the pinned version exists on PyPI before introducing it in a follow-up PR, run:
🏁 Script executed:
#!/bin/bash
set -euo pipefail
curl -s https://pypi.org/pypi/openai/json | jq -r '.releases | keys[]' | grep -Fx '1.99.1' || {
echo "Version 1.99.1 not found on PyPI for 'openai'." >&2
exit 1
}Length of output: 117
Remove OpenAI from core dependencies
The scope of LCORE-336 is to update existing dependencies — it explicitly excludes adding OpenAI. This PR introduces a new runtime dependency (openai==1.99.1), so please revert that change here or move it into its own, optional dependency group in a follow-up PR (we’ve confirmed openai==1.99.1 exists on PyPI).
• File: pyproject.toml
• Line: 36
Suggested diff to revert in this PR:
- "openai==1.99.1",If you still need OpenAI in a separate PR, consider:
+[dependency-groups]
+ai-providers = [
+ "openai==1.99.1",
+]📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "openai==1.99.1", |
🤖 Prompt for AI Agents
In pyproject.toml at line 36, the openai==1.99.1 dependency was added but should
be removed from the core dependencies as per the scope of LCORE-336. Remove the
openai==1.99.1 entry from the dependencies section in this PR. If OpenAI is
needed, add it later in a separate optional dependency group in a follow-up PR.
Related to lightspeed-core#370 A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072) Signed-off-by: Eran Cohen <eranco@redhat.com>
Related to lightspeed-core#370 A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072) Signed-off-by: Eran Cohen <eranco@redhat.com>
Related to lightspeed-core#370 A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072) Signed-off-by: Eran Cohen <eranco@redhat.com>
Description
LCORE-336: update dependencies excluding OpenAI
Type of change
Related Tickets & Documents
Summary by CodeRabbit