Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Aug 10, 2025

Description

LCORE-336: update dependencies excluding OpenAI

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-336

Summary by CodeRabbit

  • Chores
    • Updated dependencies to include the latest version of the OpenAI package.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 10, 2025

Walkthrough

The pyproject.toml file was updated to add the openai package as a dependency, specifically pinned to version 1.99.1. No other changes or additions were made to the project's configuration or dependencies.

Changes

Cohort / File(s) Change Summary
Dependency Addition
pyproject.toml
Added openai==1.99.1 to the dependencies list.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Poem

A package hops into the stack,
openai joins, no turning back!
Dependencies grow, but just by one,
The codebase preps for AI fun.
With version pinned, we’re set to go—
A bunny’s nod, and off we hop—hello! 🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@tisnik tisnik force-pushed the lcore-336-update-dependencies-excluding-openai branch from 4966f9c to 8b0f9dc Compare August 10, 2025 06:53
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8175a8 and 8b0f9dc.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-pr
  • GitHub Check: e2e_tests

"starlette>=0.47.1",
"aiohttp>=3.12.14",
"authlib>=1.6.0",
"openai==1.99.1",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Remove OpenAI addition; it contradicts PR scope (LCORE-336).

PR explicitly says “update dependencies excluding OpenAI,” but this adds a new runtime dep openai==1.99.1. Please drop this change from this PR or move it to a separate, explicitly scoped PR. If OpenAI is needed, consider placing it in a non-core dependency group (e.g., an optional group) rather than the core runtime deps.

Apply this diff to revert for this PR:

-    "openai==1.99.1",

Optionally, if needed in a separate PR, prefer an optional group:

+[dependency-groups]
+ai-providers = [
+    "openai==1.99.1",
+]

To ensure the pinned version exists on PyPI before introducing it in a follow-up PR, run:


🏁 Script executed:

#!/bin/bash
set -euo pipefail
curl -s https://pypi.org/pypi/openai/json | jq -r '.releases | keys[]' | grep -Fx '1.99.1' || {
  echo "Version 1.99.1 not found on PyPI for 'openai'." >&2
  exit 1
}

Length of output: 117


Remove OpenAI from core dependencies

The scope of LCORE-336 is to update existing dependencies — it explicitly excludes adding OpenAI. This PR introduces a new runtime dependency (openai==1.99.1), so please revert that change here or move it into its own, optional dependency group in a follow-up PR (we’ve confirmed openai==1.99.1 exists on PyPI).

• File: pyproject.toml
• Line: 36

Suggested diff to revert in this PR:

-    "openai==1.99.1",

If you still need OpenAI in a separate PR, consider:

+[dependency-groups]
+ai-providers = [
+    "openai==1.99.1",
+]
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
"openai==1.99.1",
🤖 Prompt for AI Agents
In pyproject.toml at line 36, the openai==1.99.1 dependency was added but should
be removed from the core dependencies as per the scope of LCORE-336. Remove the
openai==1.99.1 entry from the dependencies section in this PR. If OpenAI is
needed, add it later in a separate optional dependency group in a follow-up PR.

@tisnik tisnik merged commit a23527b into lightspeed-core:main Aug 10, 2025
17 of 18 checks passed
eranco74 added a commit to eranco74/lightspeed-stack that referenced this pull request Aug 10, 2025
Related to lightspeed-core#370
A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072)

Signed-off-by: Eran Cohen <eranco@redhat.com>
@eranco74 eranco74 mentioned this pull request Aug 10, 2025
17 tasks
eranco74 added a commit to eranco74/lightspeed-stack that referenced this pull request Aug 10, 2025
Related to lightspeed-core#370
A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072)

Signed-off-by: Eran Cohen <eranco@redhat.com>
eranco74 added a commit to eranco74/lightspeed-stack that referenced this pull request Aug 11, 2025
Related to lightspeed-core#370
A workaround for BerriAI/litellm#13447 (workaround for llamastack/llama-stack#3072)

Signed-off-by: Eran Cohen <eranco@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant