-
Notifications
You must be signed in to change notification settings - Fork 54
LCORE-502: unlock OpenAI package version #545
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LCORE-502: unlock OpenAI package version #545
Conversation
WalkthroughThe dependency specification for the OpenAI package in pyproject.toml was updated from an exact pin (==1.99.9) to a minimum-version constraint (>=1.99.9). No other files or configuration values were changed. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Possibly related PRs
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
uv.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
- GitHub Check: build-pr
- GitHub Check: e2e_tests
🔇 Additional comments (3)
pyproject.toml (3)
46-46: uv.lock updated — verify CI consumes ituv.lock (repo root) pins openai to 1.99.9 (sdist + wheel entries present; upload-time 2025-08-12), and pyproject lists "openai>=1.99.9" — lockfile is in sync. Verify your CI workflows install from/lock against uv.lock (or update workflows) so builds remain reproducible.
46-46: Double‑check upstream release cadence before widening.Latest stable openai Python package: 1.107.1 (released Sept 10, 2025). No single sweeping runtime-breaking rework is documented since 1.99.9, but incremental feature/typing/private‑internal changes exist — review the GitHub Releases/CHANGELOG for per‑version breaking/deprecation notes before widening the range (pyproject.toml, line 46: "openai>=1.99.9").
46-46: Verify OpenAI SDK usage — remove or migrate dependencypyproject.toml contains "openai>=1.99.9" (pyproject.toml:46); a repo scan found no legacy v0 calls (openai.ChatCompletion.create / Completion.create / Image.create / Embedding.create) nor direct v1-client imports/usages (from openai import OpenAI, OpenAI(), client.chat/completions/images/embeddings). Confirm whether the package is required (remove if unused), or migrate any dynamic/indirect usage to the v1 client and/or document intentional coexistence and compatibility tests.
| # OpenAPI exporter | ||
| "email-validator>=2.2.0", | ||
| "openai==1.99.9", | ||
| "openai>=1.99.9", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add an upper bound to prevent accidental breaking upgrades.
Unbounded minimum (openai>=1.99.9) can pull a future major with breaking API changes. Prefer a capped range.
Apply this diff:
- "openai>=1.99.9",
+ "openai>=1.99.9,<2.0.0",Optional: If you specifically want to allow only compatible minor/patch under PEP 440, use ~=1.99.9 (caps at <1.100.0), but <2.0.0 is usually clearer.
📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
| "openai>=1.99.9", | |
| "openai>=1.99.9,<2.0.0", |
🤖 Prompt for AI Agents
In pyproject.toml around line 46, the openai dependency is specified as an
unbounded minimum ("openai>=1.99.9"); change it to a range that prevents pulling
a future major with breaking API changes by adding an upper bound (for example
use a capped range of >=1.99.9 and <2.0.0 or use the compatible release operator
~=1.99.9 which caps at <1.100.0) so the dependency will not unexpectedly upgrade
to a breaking major version.
Description
LCORE-502: unlock OpenAI package version
Type of change
Related Tickets & Documents
Summary by CodeRabbit