-
Notifications
You must be signed in to change notification settings - Fork 58
LCORE-637: Bundle jq and patch with the image #503
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughBumps uv from 0.8.11 to 0.8.15 in both builder and final stages of the Containerfile; adds a root-user step in the final stage and a microdnf install of Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Pre-merge checks (3 passed)✅ Passed checks (3 passed)
Poem
Tip 👮 Agentic pre-merge checks are now available in preview!Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.
Please see the documentation for more information. Example: reviews:
pre_merge_checks:
custom_checks:
- name: "Undocumented Breaking Changes"
mode: "warning"
instructions: |
Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).Please share your feedback with us on this Discord post. 📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
Containerfile (2)
20-20: Pin uv once and avoid pip cacheUse an ARG to deduplicate the uv version across stages and prevent caching to keep layers small.
-RUN pip3.12 install "uv==0.8.15" +RUN pip3.12 install --no-cache-dir "uv==0.8.15" && pip3.12 cache purgeOutside this hunk (suggested):
# near the top of each stage ARG UV_VERSION=0.8.15 # ... RUN pip3.12 install --no-cache-dir "uv==${UV_VERSION}" && pip3.12 cache purgePlease confirm 0.8.15 is still the intended uv version for this release cadence.
60-61: Final stage uv install: same no-cache + fix stale comment
- Apply the same no-cache/purge pattern here.
- The comment at Line 37 says “Final image without uv package manager” but uv is installed below—update it.
-RUN pip3.12 install "uv==0.8.15" +RUN pip3.12 install --no-cache-dir "uv==0.8.15" && pip3.12 cache purge
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (1)
Containerfile(2 hunks)
🧰 Additional context used
🪛 GitHub Actions: E2E Tests
Containerfile
[error] 63-63: Command 'RUN microdnf install -y --nodocs --setopt=keepcache=0 --setopt=tsflags=nodocs jq patch' failed. Exit code 1. Error: 'error: Failed to create: /var/cache/yum/metadata'.
[warning] 1-1: librhsm-WARNING: Found 0 entitlement certificates.
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: build-pr
🔇 Additional comments (1)
Containerfile (1)
62-63: Robustify microdnf install step
Create the missing cache directories, enable UBI 9 BaseOS/AppStream repos, disable weak deps, drop the redundant tsflags (since --nodocs is already used), and clean all caches to avoid the “Failed to create: /var/cache/yum/metadata” error.
Please verify the actual repo IDs by runningmicrodnf repolistinside a local ubi9/python-312-minimal container and adjust the --enablerepo flags as needed.
manstis
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
tisnik
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
LCORE-637: Bundle jq and patch with the image
Type of change
Related Tickets & Documents
Checklist before requesting a review
Testing
Summary by CodeRabbit