Skip to content

Conversation

@tisnik
Copy link
Contributor

@tisnik tisnik commented Sep 25, 2025

Description

LCORE-298: New dependency on PsycoPG2

Type of change

  • Refactor
  • New feature
  • Bug fix
  • CVE fix
  • Optimization
  • Documentation Update
  • Configuration Update
  • Bump-up service version
  • Bump-up dependent library
  • Bump-up library or tool used for development (does not change the final image)
  • CI configuration change
  • Konflux configuration change
  • Unit tests improvement
  • Integration tests improvement
  • End to end tests improvement

Related Tickets & Documents

  • Related Issue #LCORE-298

Summary by CodeRabbit

  • Chores
    • Added psycopg2-binary (>=2.9.10) to project dependencies.
    • Adjusted dependency list formatting without altering existing behavior.
    • No changes to public APIs or features; functionality remains unchanged.
    • Installation now includes an additional package to satisfy runtime requirements.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Sep 25, 2025

Walkthrough

Added a new runtime dependency psycopg2-binary (>=2.9.10) in pyproject.toml; no code or API changes.

Changes

Cohort / File(s) Summary
Dependency declaration update
pyproject.toml
Added psycopg2-binary>=2.9.10 to dependencies; adjusted trailing comma around jsonpath-ng entry without semantic change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

I nibbled the deps with a careful hop,
Added psycopg2-binary to our shop.
Carrots aligned, commas just so—
Packages stacked, ready to go.
Thump goes the paw: “Ship it, yo!” 🥕🐇

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title succinctly identifies the main change by stating the JIRA ticket and that a new PsycoPG2 dependency is being added, directly reflecting the changes in the PR.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7173f72 and 558732a.

⛔ Files ignored due to path filters (1)
  • uv.lock is excluded by !**/*.lock
📒 Files selected for processing (1)
  • pyproject.toml (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
pyproject.toml

📄 CodeRabbit inference engine (CLAUDE.md)

pyproject.toml: ALWAYS check pyproject.toml for existing dependencies before adding new ones
ALWAYS verify current library versions in pyproject.toml rather than assuming versions
Prefer reading supported Python versions and tool configs from pyproject.toml

Files:

  • pyproject.toml
🧠 Learnings (2)
📓 Common learnings
Learnt from: matysek
PR: lightspeed-core/lightspeed-stack#292
File: pyproject.toml:47-47
Timestamp: 2025-08-18T10:58:14.951Z
Learning: psycopg2-binary is required by some llama-stack providers in the lightspeed-stack project, so it cannot be replaced with psycopg v3 or moved to optional dependencies without breaking llama-stack functionality.
📚 Learning: 2025-08-18T10:58:14.951Z
Learnt from: matysek
PR: lightspeed-core/lightspeed-stack#292
File: pyproject.toml:47-47
Timestamp: 2025-08-18T10:58:14.951Z
Learning: psycopg2-binary is required by some llama-stack providers in the lightspeed-stack project, so it cannot be replaced with psycopg v3 or moved to optional dependencies without breaking llama-stack functionality.

Applied to files:

  • pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build-pr
  • GitHub Check: mypy
  • GitHub Check: e2e_tests
🔇 Additional comments (1)
pyproject.toml (1)

52-53: Dependency addition aligns with llama-stack requirements.

The new psycopg2-binary>=2.9.10 entry matches the version already used in the llslibdev group and satisfies the previously noted llama-stack provider dependency, so this upgrade looks good.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@tisnik tisnik merged commit 6529c37 into lightspeed-core:main Sep 25, 2025
18 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant