feat(rlsapi): add method to combine request inputs

[major]

Description

Adds input handling for the rlsapi v1 interface. Joins non-empty sources (question, stdin, attachment, terminal) with double newlines for LLM inference.

Type of change

• Refactor
• New feature
• Bug fix
• CVE fix
• Optimization
• Documentation Update
• Configuration Update
• Bump-up service version
• Bump-up dependent library
• Bump-up library or tool used for development (does not change the final image)
• CI configuration change
• Konflux configuration change
• Unit tests improvement
• Integration tests improvement
• End to end tests improvement

Tools used to create PR

• Assisted-by: Claude

Related Tickets & Documents

• Related Issue #
• Closes #

Checklist before requesting a review

• I have performed a self-review of my code.
• PR has passed all pre-merge test jobs.
• If it is a core feature, I have added thorough tests.

Testing

Existing unit tests should be sufficient.

Summary by CodeRabbit

• New Features

  • Adds consolidated input assembly that merges multiple input sources into a single prioritized input string, preserving content formatting.

• Tests

  • Introduces comprehensive unit tests covering combinations of input sources, multiline content preservation, and explicit priority ordering validation.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Added RlsapiV1InferRequest.get_input_source(), which builds a single string by concatenating non-empty sources (question, context.stdin, context.attachments.contents, context.terminal.output) in that priority order, separated by double newlines. Added unit tests covering combinations and edge cases.

Changes

Cohort / File(s)	Summary
Production Implementation src/models/rlsapi/requests.py	Added instance method get_input_source(self) -> str on RlsapiV1InferRequest that concatenates non-empty inputs in priority order: question → context.stdin → context.attachments.contents → context.terminal.output, joined with "\n\n".
Unit Tests tests/unit/models/rlsapi/test_requests.py	Added TestGetInputSource with a make_request fixture, parameterized test_input_combinations covering all combinations of sources, and edge-case tests test_preserves_content_formatting and test_priority_order.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

• Review points:
  • Verify handling of None vs empty-string for each source.
  • Confirm attachments/content access (structure of context.attachments.contents) matches expected runtime shape.
  • Check preservation of multiline content and exact separator usage ("\n\n").
  • Ensure tests cover all intended priority and formatting edge cases.

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately reflects the main change: adding a method (get_input_source) to combine/concatenate request inputs in the RlsapiV1InferRequest class.
Docstring Coverage	✅ Passed	Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between e22ca6e and 8272057.

📒 Files selected for processing (2)

• src/models/rlsapi/requests.py (1 hunks)
• tests/unit/models/rlsapi/test_requests.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

src/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

src/**/*.py: Use absolute imports for internal modules in LCS project (e.g., from auth import get_auth_dependency)
All modules must start with descriptive docstrings explaining their purpose
Use logger = logging.getLogger(__name__) pattern for module logging
All functions must include complete type annotations for parameters and return types, using modern syntax (str | int) and Optional[Type] or Type | None
All functions must have docstrings with brief descriptions following Google Python docstring conventions
Function names must use snake_case with descriptive, action-oriented names (get_, validate_, check_)
Avoid in-place parameter modification anti-patterns; return new data structures instead of modifying input parameters
Use async def for I/O operations and external API calls
All classes must include descriptive docstrings explaining their purpose following Google Python docstring conventions
Class names must use PascalCase with descriptive names and standard suffixes: Configuration for config classes, Error/Exception for exceptions, Resolver for strategy patterns, Interface for abstract base classes
Abstract classes must use ABC with @abstractmethod decorators
Include complete type annotations for all class attributes in Python classes
Use import logging and module logger pattern with standard log levels: debug, info, warning, error

Files:

• src/models/rlsapi/requests.py

src/models/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

src/models/**/*.py: Use @field_validator and @model_validator for custom validation in Pydantic models
Pydantic configuration classes must extend ConfigurationBase; data models must extend BaseModel

Files:

• src/models/rlsapi/requests.py

tests/{unit,integration}/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/{unit,integration}/**/*.py: Use pytest for all unit and integration tests; do not use unittest framework
Unit tests must achieve 60% code coverage; integration tests must achieve 10% coverage

Files:

• tests/unit/models/rlsapi/test_requests.py

tests/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

Use pytest-mock with AsyncMock objects for mocking in tests

Files:

• tests/unit/models/rlsapi/test_requests.py

🧬 Code graph analysis (1)

tests/unit/models/rlsapi/test_requests.py (1)

src/models/rlsapi/requests.py (4)

• RlsapiV1Context (89-120)
• RlsapiV1Attachment (8-25)
• RlsapiV1Terminal (28-39)
• get_input_source (178-200)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build-pr
• GitHub Check: E2E: library mode / ci
• GitHub Check: E2E: library mode / azure
• GitHub Check: E2E: server mode / azure
• GitHub Check: E2E: server mode / ci

🔇 Additional comments (2)

src/models/rlsapi/requests.py (1)

177-200: get_input_source implementation matches the described input-combining behavior

The method is concise, side‑effect free, and correctly respects the documented priority order and separator ("\n\n"), while omitting only truly empty sources. Localizing the pylint: disable=no-member comment here keeps the rest of the file clean. No changes needed.

tests/unit/models/rlsapi/test_requests.py (1)

316-463: Thorough tests for get_input_source combinations and ordering

The factory fixture plus parametrized cases exercise all relevant source‑presence combinations and verify both exact formatting and ordering, including multiline content preservation. This gives strong regression protection for the new helper without adding unnecessary complexity.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

Hi @major. Thanks for your PR.

I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

Actionable comments posted: 0

🧹 Nitpick comments (2)

src/models/rlsapi/requests.py (2)

3-10: Logger initialized but never used.

The module logger is defined following the correct pattern, but it's not used anywhere in the file. The new get_input_source() method doesn't emit any log statements.

Consider either:

• Removing the logger if not needed yet
• Adding a comment explaining it's reserved for future use
• Adding debug logging in get_input_source() if useful for troubleshooting

---

182-204: Implementation looks good with minor style suggestion.

The method correctly concatenates non-empty input sources in the documented priority order using double newlines. The logic is clear and the docstring is comprehensive.

Minor suggestion: The # pylint: disable=no-member comment on line 197 could be moved to line 182 (at the function level) for better scope clarity:

 def get_input_source(self) -> str:
     """Combine all non-empty input sources into a single string.
     
     Joins question, stdin, attachment contents, and terminal output with double
     newlines, in priority order. Empty sources are omitted.
     
     Priority order:
         1. question
         2. stdin
         3. attachment contents
         4. terminal output
     
     Returns:
         The combined input string with sources separated by double newlines.
     """
+    # pylint: disable=no-member
     parts = [
         self.question,
         self.context.stdin,
         self.context.attachments.contents,
         self.context.terminal.output,
     ]
     return "\n\n".join(part for part in parts if part)

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 668d09c and e22ca6e.

📒 Files selected for processing (2)

• src/models/rlsapi/requests.py (2 hunks)
• tests/unit/models/rlsapi/test_requests.py (1 hunks)

🧰 Additional context used

📓 Path-based instructions (4)

tests/{unit,integration}/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

tests/{unit,integration}/**/*.py: Use pytest for all unit and integration tests; do not use unittest framework
Unit tests must achieve 60% code coverage; integration tests must achieve 10% coverage

Files:

• tests/unit/models/rlsapi/test_requests.py

tests/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

Use pytest-mock with AsyncMock objects for mocking in tests

Files:

• tests/unit/models/rlsapi/test_requests.py

src/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

src/**/*.py: Use absolute imports for internal modules in LCS project (e.g., from auth import get_auth_dependency)
All modules must start with descriptive docstrings explaining their purpose
Use logger = logging.getLogger(__name__) pattern for module logging
All functions must include complete type annotations for parameters and return types, using modern syntax (str | int) and Optional[Type] or Type | None
All functions must have docstrings with brief descriptions following Google Python docstring conventions
Function names must use snake_case with descriptive, action-oriented names (get_, validate_, check_)
Avoid in-place parameter modification anti-patterns; return new data structures instead of modifying input parameters
Use async def for I/O operations and external API calls
All classes must include descriptive docstrings explaining their purpose following Google Python docstring conventions
Class names must use PascalCase with descriptive names and standard suffixes: Configuration for config classes, Error/Exception for exceptions, Resolver for strategy patterns, Interface for abstract base classes
Abstract classes must use ABC with @abstractmethod decorators
Include complete type annotations for all class attributes in Python classes
Use import logging and module logger pattern with standard log levels: debug, info, warning, error

Files:

• src/models/rlsapi/requests.py

src/models/**/*.py

📄 CodeRabbit inference engine (CLAUDE.md)

src/models/**/*.py: Use @field_validator and @model_validator for custom validation in Pydantic models
Pydantic configuration classes must extend ConfigurationBase; data models must extend BaseModel

Files:

• src/models/rlsapi/requests.py

🧬 Code graph analysis (2)

tests/unit/models/rlsapi/test_requests.py (1)

src/models/rlsapi/requests.py (5)

• RlsapiV1InferRequest (127-204)
• RlsapiV1Context (93-124)
• RlsapiV1Attachment (12-29)
• RlsapiV1Terminal (32-43)
• get_input_source (182-204)

src/models/rlsapi/requests.py (1)

src/models/config.py (2)

• config (324-341)
• ConfigurationBase (33-36)

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (5)

• GitHub Check: build-pr
• GitHub Check: E2E: server mode / azure
• GitHub Check: E2E: library mode / ci
• GitHub Check: E2E: library mode / azure
• GitHub Check: E2E: server mode / ci

🔇 Additional comments (1)

tests/unit/models/rlsapi/test_requests.py (1)

316-463: Excellent test coverage for the new method.

The test suite comprehensively validates get_input_source():

• Parameterized tests cover all meaningful input combinations (all four sources through question-only)
• Edge cases verify multiline content preservation and strict priority ordering
• Factory fixture pattern keeps tests clean and readable

The tests follow pytest best practices and align well with the coding guidelines.

[tisnik]

LGTM

[tisnik]

/ok-to-test