Pull request template#20
Merged
tisnik merged 1 commit intolightspeed-core:mainfrom Jun 5, 2025
Merged
Conversation
Contributor
|
Thanks, the checklist is helpful! |
romartin
added a commit
to romartin/rag-content
that referenced
this pull request
Apr 1, 2026
- Use /usr/bin/skopeo absolute path (lightspeed-core#18) - Add timeout=300 and stderr capture to _fetch_base_archive; wrap CalledProcessError and TimeoutExpired with descriptive RuntimeError messages including skopeo's stderr (lightspeed-core#19/lightspeed-core#23) - Remove confusing gzip/diffutils/RUN comment (lightspeed-core#20) - Streaming refactor: _make_layer_tar writes to a temp file and returns sha256 computed by chunked read; _read_docker_archive returns layer names only (no layer bytes); build_image_archive streams base layers directly from the skopeo archive and custom layer from its temp file, keeping peak RAM independent of image size (lightspeed-core#21/lightspeed-core#22) - Validate --model-dir exists before building image archive; fail fast with FileNotFoundError pointing to --exclude-model (lightspeed-core#25) - Fix corrupted README heading (merge artifact) - Update tests for all of the above; add test_returns_sha256_hex, test_layer_data_not_loaded, test_main_raises_if_model_dir_missing Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request template