Skip to content

Conversation

@xdrdak
Copy link
Contributor

@xdrdak xdrdak commented Jul 6, 2020

Description

Typings was a bit too aggressive for themeGet. Set the theme as optional.

How to test?

  • Checkout branch, run yarn dev
  • Open Storybook
  • Or check the deploy preview on Netlify (link available in comments)

Checklist

@xdrdak xdrdak requested a review from a team as a code owner July 6, 2020 16:11
@xdrdak xdrdak merged commit 39cee4b into master Jul 6, 2020
@xdrdak xdrdak deleted the patch-theme-get branch July 6, 2020 16:14
@xdrdak xdrdak restored the patch-theme-get branch July 6, 2020 16:15
@netlify
Copy link

netlify bot commented Jul 6, 2020

Deploy preview for lightspeed-flame ready!

Built with commit 8844c49

https://deploy-preview-116--lightspeed-flame.netlify.app

@netlify
Copy link

netlify bot commented Jul 6, 2020

Deploy preview for lightspeed-flame ready!

Built with commit 2ac193b

https://deploy-preview-116--lightspeed-flame.netlify.app

xdrdak added a commit that referenced this pull request Jul 6, 2020
* Loosen typings for themeGet

* Update CHANGELOG.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants