Epic: Migrate All Bash Scripts to JavaScript

[ashleyshaw]

Overview

This epic tracks the complete migration of all shell scripts to JavaScript with Jest test coverage, ensuring a JavaScript-only infrastructure across the organisation.

Shell Scripts Inventory

Script	Location	Type	Priority	Status
validate-design-md.sh	design-md-generator/scripts/	Design validation	P1	✅ COMPLETED (PR #624)
ci-design-md-check.sh	design-md-generator/scripts/	Design CI check	P1	✅ COMPLETED (PR #625)
quick_check_skill.sh	Multiple (2x)	Skill validation	P2	✅ COMPLETED (PR #631)
package_skill_zip.sh	Multiple (2x)	Skill packaging	P2	Pending
install_deps.sh	pdfs/js/	Dependency install	P3	Pending

Migration Strategy

1. Create JavaScript equivalents in scripts/ directory structure
2. Write comprehensive Jest tests for each module
3. Create PRs for each migration with passing tests
4. Merge PRs to develop branch
5. Remove corresponding shell scripts

Success Criteria

• quick_check_skill.sh migration completed (PR feat: Migrate quick_check_skill.sh to JavaScript (validateSkillStructure) #631 merged)
• validate-design-md.sh migration completed (PR feat: Migrate validate-design-md.sh to JavaScript #624 merged)
• ci-design-md-check.sh migration completed (PR feat: Migrate ci-design-md-check.sh to JavaScript #625 merged)
• All remaining shell scripts migrated to JavaScript
• Each module has Jest tests with >80% coverage
• All tests passing
• Zero shell scripts in repository (except git hooks)
• Workflows and CI updated to use JavaScript versions
• Documentation updated

Completed Migrations

• ✅ Migrate: Replace quick_check_skill.sh with JavaScript #613: quick_check_skill.sh → validateSkillStructure.js (merged in PR feat: Migrate quick_check_skill.sh to JavaScript (validateSkillStructure) #631)
• ✅ Migrate: Replace validate-design-md.sh with JavaScript #611: validate-design-md.sh → validateDesignMd.js (merged in PR feat: Migrate validate-design-md.sh to JavaScript #624)
• ✅ Migrate: Replace ci-design-md-check.sh with JavaScript #612: ci-design-md-check.sh → ciDesignMdCheck.js (merged in PR feat: Migrate ci-design-md-check.sh to JavaScript #625)

Remaining Migrations

• #[package-skill-zip-issue]: package_skill_zip.sh → packageSkillZip.js
• #[install-deps-issue]: install_deps.sh → installDeps.js

Related Issues

• Migrate: Replace quick_check_skill.sh with JavaScript #613 - ✅ COMPLETED
• Migrate: Replace validate-design-md.sh with JavaScript #611 - ✅ COMPLETED
• Migrate: Replace ci-design-md-check.sh with JavaScript #612 - ✅ COMPLETED
• #[package-skill-zip-issue]
• #[install-deps-issue]

Timeline

Target: June 2026

[linear-code]

LS-805

[ashleyshaw]

Progress Update: P2 Migration (packageSkillZip) Underway

PR #638 has been created for the package_skill_zip.sh → packageSkillZip.js migration:

• ✅ Module implementation complete with execSync for zip command
• ✅ Comprehensive Jest test suite: 15 tests, all passing
• ✅ Validation integration with updated validateSkillStructure
• ⏳ CI jobs queued (check, validate, linting, testing)
• ⏳ Awaiting CI completion before merge

Next steps after merge:

1. Update epic P2 status to ✅ COMPLETED
2. Begin P3 migration: install_deps.sh → installDeps.js
3. Clean up old shell scripts once all migrations verified

---

Generated by Claude Code

[ashleyshaw]

✅ P2 Migration Complete: packageSkillZip

PR #638 has been merged!

Completed with security improvements:

• ✅ Command injection vulnerability fixed (execFileSync instead of execSync)
• ✅ Code quality: Async function with proper return/throw pattern
• ✅ Removed unused archiver dependency
• ✅ All 15 tests passing with 100% coverage for packageSkillZip.js
• ✅ Updated validateSkillStructure with checkPackageNoise option

Remaining Migrations:

• P3: install_deps.sh → installDeps.js (1 location: pdfs/js/)

Status Update:

Script	Status
validate-design-md.sh	✅ COMPLETED (PR #624)
ci-design-md-check.sh	✅ COMPLETED (PR #625)
quick_check_skill.sh	✅ COMPLETED (PR #631)
package_skill_zip.sh	✅ COMPLETED (PR #638)
install_deps.sh	🔄 NEXT (P3)

---

Generated by Claude Code

[ashleyshaw]

Test Infrastructure Blockers Identified

During PR #634 (planner agent enhancements), we discovered three critical infrastructure issues blocking all PRs from merging, regardless of code quality:

Infrastructure Issues Created

1. #[issue-num] — Test suite ESM/TextDecoder compatibility

   • Jest failing to polyfill TextDecoder in ESM mode
   • Blocks: Testing workflow, all PRs

2. #[issue-num] — Planner agent schema validation

   • Planner schema validation setup failure
   • Blocks: planner check, all PRs

3. #[issue-num] — Fixture validation test

   • Fixture schema/setup issue
   • Blocks: validate/check workflows, all PRs

Impact

These infrastructure failures are not code quality issues — they prevent any PR from passing CI, regardless of implementation quality. Fixing them would unblock all pending PRs and improve developer experience significantly.

Recommendation

Consider prioritizing these three fixes as part of the JavaScript migration work (#616) to restore full CI/CD pipeline functionality.

---

Created as part of PR #634 investigation

---

Generated by Claude Code