Skip to content

fix(ci): implement issue #419 labeler hardening #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ashleyshaw merged 5 commits into from
May 27, 2026
Merged

fix(ci): implement issue #419 labeler hardening #427

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f2349c
fix(ci): harden labeling workflow config validation
ashleyshaw May 27, 2026
e934c38
fix(deps): resolve puppeteer and mermaid-cli peer conflict
ashleyshaw May 27, 2026
7203413
docs(migration): record #419 workflow decision
ashleyshaw May 27, 2026
01b9565
chore(deps): remove unused puppeteer and align mermaid-cli
ashleyshaw May 27, 2026
7928c71
chore(docs): drop unrelated docs from #419 scope
ashleyshaw May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 3 additions & 10 deletions .github/workflows/labeling.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ jobs:
- name: Install dependencies
run: npm ci

- name: Validate labeling config schema
run: node scripts/validation/validate-labeling-configs.cjs

- name: Sync labels with canonical set
run: |
node scripts/agents/includes/label-sync.js
Expand All @@ -79,16 +82,6 @@ jobs:
shell: bash
continue-on-error: false

# NOTE: Disabled due to schema incompatibility in labeler.yml with actions/labeler v5.
# Unified labeling is handled by scripts/agents/labeling.agent.js below.
- name: File/branch labeler (actions/labeler)
if: ${{ false }}
uses: actions/labeler@v5
with:
repo-token: ${{ secrets.GITHUB_TOKEN }}
configuration-path: ${{ env.LABELER_RULES }}
sync-labels: true

# Run unified labeling agent for issues and PRs
- name: Run labeling agent
env:
Expand Down
14 changes: 13 additions & 1 deletion docs/MIGRATION.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
---
title: "Migration Notes"
description: "Central migration map and contributor guidance for repository-wide naming, label, and configuration changes."
version: "v0.1.0"
version: "v0.2.0"
last_updated: "2026-05-27"
file_type: "documentation"
maintainer: "LightSpeed Team"
Expand Down Expand Up @@ -86,3 +86,15 @@ maintainer approves the intended mapping.
deletion or archival.
- If a legacy label is still actively used and the mapping is ambiguous, document
the decision here before changing live GitHub labels.

## Workflow Migration Notes

### 2026-05-27 — Labeler Hardening (Issue #419)

- `actions/labeler@v5` execution was retired from the labeling workflow due to
persistent schema incompatibility with the canonical `labeler.yml` structure.
Comment on lines +94 to +95
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot May 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

Use UK English in prose for consistency.

Please change “labeling workflow” to “labelling workflow” in this sentence (keep code identifiers like labeling.agent.js unchanged).

As per coding guidelines, "Keep wording in UK English."

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/MIGRATION.md` around lines 94 - 95, Update the prose to UK English by
replacing the phrase "labeling workflow" with "labelling workflow" while keeping
code identifiers unchanged (leave `actions/labeler@v5`, `labeler.yml` and
filenames like `labeling.agent.js` intact); edit the sentence containing
"actions/labeler@v5 execution was retired from the labeling workflow..." so it
reads "...retired from the labelling workflow..." and ensure no other code
tokens are modified.

- The unified runtime path is now `scripts/agents/labeling.agent.js`, backed by
canonical configs in `.github/labels.yml`, `.github/issue-types.yml`, and
`.github/labeler.yml`.
- A fail-fast schema gate now validates those three config files before label
execution in CI.
Loading
Loading