fix: replace deprecated MCP tool refs (create_issue → issue_write, get_issue → issue_read)#455
Conversation
…e_write/issue_read Updates four files to use current MCP tool names: - create_issue → issue_write - update_issue → issue_write (same tool, method: create|update) - get_issue → issue_read Closes #52
|
Warning Review limit reached
More reviews will be available in 27 minutes and 34 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (11)
Note
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request replaces deprecated GitHub issue tools (create_issue, update_issue, and get_issue) with the new unified tools (issue_write and issue_read) across several prompt and agent markdown files. It also updates related descriptions and standardizes spelling to British English (e.g., "analyse", "organise", "finalising", "authorisation"). The reviewer recommends documenting these tool migrations in the central /docs/MIGRATION.md file to help contributors follow migration rules across the repository.
| "issue_write", | ||
| "issue_read", |
There was a problem hiding this comment.
When migrating deprecated tools (such as create_issue, update_issue, and get_issue to issue_write and issue_read), please ensure that these migration maps and notes are documented in the central /docs/MIGRATION.md file. This helps contributors follow migration rules across the repository.
References
- Document migration maps and notes in a central
/docs/MIGRATION.mdfile to ensure contributors can follow migration rules mentioned in README files across the repository.
There was a problem hiding this comment.
The PR scope is limited to updating deprecated tool names in the agent spec — it doesn't introduce a migration system or process. A /docs/MIGRATION.md file is out of scope here and would require a separate issue to define what that document should contain and who maintains it. Declining this suggestion.
Generated by Claude Code
…n't throw
`run()` was called at module scope unconditionally. When Jest's test file
does `require('../project-meta-sync.agent')` the function executes immediately,
throws "LS_PROJECT_URL not set", and sets process.exitCode = 1, failing the
entire test suite. Guard with `require.main === module` so the side-effect only
fires when the script is run directly by Node/Actions.
Add a typeof check and an explicit exit-code assertion so the test fails visibly if require() triggers run() and corrupts process.exitCode.
…removed) Node 24 removed the built-in `punycode` module that was only deprecated in Node 22. @stoplight/spectral-core still requires it, so `lint:yaml` and `lint:workflows` crash immediately. Node 22 LTS (EOL Apr 2027) is the highest version all current dependencies support without errors.
- Fix skills/design-md-agent/pdfs/js/package.json: add @lightspeedwp scope and required fields (description, license, author, repository) - Fix .schemas/README.md: resolve git merge conflict markers - Fix scripts/agents/__tests__/reviewer.agent.test.js: avoid require() on module that uses import.meta.url; check file existence instead
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c4f4a5d56a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| tags: ["schemas", "validation", "ai-ops", "governance"] | ||
| status: "active" | ||
| >>>>>>> 047fdbf127701a21a10b81aed33d4e5db86cc48b | ||
| stability: "active" |
There was a problem hiding this comment.
This changes the README frontmatter to stability: "active", but I checked .schemas/frontmatter.schema.json and stability is limited to stable, experimental, or incubating; active belongs to the separate status field. Any run of the frontmatter validator over this README will keep reporting this file as invalid, so please use a valid stability value or add status: "active" separately.
Useful? React with 👍 / 👎.
…RIBUTING fixes, project-meta-sync guard Applies changes from PRs #455, #457, #460 (merged into main) to develop: - agents/mode-prd.agent.md: remove `update_issue`, keep `issue_write`/`issue_read` - .github/prompts/*.prompt.md (3 files): remove `update_issue`, UK English - CONTRIBUTING.md: remove `references` frontmatter field, fix stale body date, UK English pass - .github/ISSUE_TEMPLATE/02-bug.md: expand single DoD line → three discrete items (WCAG 2.2 AA / OWASP / perf) - .github/ISSUE_TEMPLATE/03-feature.md: same DoD expansion - scripts/agents/project-meta-sync.agent.js: add require.main guard + module.exports
…after merging #455 #457 #460 - CHANGELOG.md: add Fixed + Documentation entries for the three merged PRs - next-issues-execution-plan: mark #52/#18/#21 closed, Wave 1 complete, #60 next; add PR branching note - spec-only-agents-issue-conversion: bump last_updated - launch-agents-checklist: bump last_updated, note project-meta-sync + reviewer test fixes
* fix: replace deprecated MCP tool refs (create_issue → issue_write, get_issue → issue_read) (#455) * fix: replace deprecated create_issue/update_issue/get_issue with issue_write/issue_read Updates four files to use current MCP tool names: - create_issue → issue_write - update_issue → issue_write (same tool, method: create|update) - get_issue → issue_read Closes #52 * fix(test): guard project-meta-sync auto-run so require() in Jest doesn't throw `run()` was called at module scope unconditionally. When Jest's test file does `require('../project-meta-sync.agent')` the function executes immediately, throws "LS_PROJECT_URL not set", and sets process.exitCode = 1, failing the entire test suite. Guard with `require.main === module` so the side-effect only fires when the script is run directly by Node/Actions. * test: strengthen project-meta-sync guard assertions Add a typeof check and an explicit exit-code assertion so the test fails visibly if require() triggers run() and corrupts process.exitCode. * fix(ci): pin Node to v22 LTS — spectral crashes on Node 24 (punycode removed) Node 24 removed the built-in `punycode` module that was only deprecated in Node 22. @stoplight/spectral-core still requires it, so `lint:yaml` and `lint:workflows` crash immediately. Node 22 LTS (EOL Apr 2027) is the highest version all current dependencies support without errors. * debug(ci): split check into individual steps to identify failing step * debug(ci): add HUSKY=0 and split steps to pinpoint failure * fix(ci): resolve lint and test failures blocking CI - Fix skills/design-md-agent/pdfs/js/package.json: add @lightspeedwp scope and required fields (description, license, author, repository) - Fix .schemas/README.md: resolve git merge conflict markers - Fix scripts/agents/__tests__/reviewer.agent.test.js: avoid require() on module that uses import.meta.url; check file existence instead * docs: CONTRIBUTING.md — remove references frontmatter, npm ci, date fix (#457) * docs: remove references frontmatter, fix npm install → npm ci, update stale date - Remove `references` frontmatter field (violates repo convention; use inline links instead) - Quick Start step 2: `npm install` → `npm ci` for reproducible installs - Update stale "Last Updated: 2025-10-21" body line to 2026-05-27 Closes #18 * fix(test): guard project-meta-sync auto-run so require() in Jest doesn't throw `run()` was called at module scope unconditionally. When Jest's test file does `require('../project-meta-sync.agent')` the function executes immediately, throws "LS_PROJECT_URL not set", and sets process.exitCode = 1, failing the entire test suite. Guard with `require.main === module` so the side-effect only fires when the script is run directly by Node/Actions. * test: strengthen project-meta-sync guard assertions Add a typeof check and an explicit exit-code assertion so the test fails visibly if require() triggers run() and corrupts process.exitCode. * fix(ci): pin Node to v22 LTS — spectral crashes on Node 24 (punycode removed) Node 24 removed the built-in `punycode` module that was only deprecated in Node 22. @stoplight/spectral-core still requires it, so `lint:yaml` and `lint:workflows` crash immediately. Node 22 LTS (EOL Apr 2027) is the highest version all current dependencies support without errors. * fix(ci): resolve lint and test failures blocking CI - Fix skills/design-md-agent/pdfs/js/package.json: add @lightspeedwp scope and required fields (description, license, author, repository) - Fix .schemas/README.md: resolve git merge conflict markers - Fix scripts/agents/__tests__/reviewer.agent.test.js: avoid require() on module that uses import.meta.url; check file existence instead * fix: add explicit accessibility and security DoD checklist items to issue templates (#460) * fix: add explicit accessibility and security DoD checklist items to issue templates - 02-bug.md DoD: replace single "No adverse impact on performance or security" line with discrete checklist items for WCAG 2.2 AA and OWASP Top 10 - 03-feature.md DoD: expand "Accessibility, performance, security checks (where relevant)" into three discrete checklist items matching PR template standards Closes #21 * fix(test): guard project-meta-sync auto-run so require() in Jest doesn't throw `run()` was called at module scope unconditionally. When Jest's test file does `require('../project-meta-sync.agent')` the function executes immediately, throws "LS_PROJECT_URL not set", and sets process.exitCode = 1, failing the entire test suite. Guard with `require.main === module` so the side-effect only fires when the script is run directly by Node/Actions. * test: strengthen project-meta-sync guard assertions Add a typeof check and an explicit exit-code assertion so the test fails visibly if require() triggers run() and corrupts process.exitCode. * fix(ci): pin Node to v22 LTS — spectral crashes on Node 24 (punycode removed) Node 24 removed the built-in `punycode` module that was only deprecated in Node 22. @stoplight/spectral-core still requires it, so `lint:yaml` and `lint:workflows` crash immediately. Node 22 LTS (EOL Apr 2027) is the highest version all current dependencies support without errors. * fix(template): add Performance: prefix to bug DoD item for consistency Aligns with the Accessibility: and Security: prefix style on the adjacent checklist items, as suggested in review. * fix(template): restore bug template with Performance: prefix on DoD item Restores the accidental empty-file push and applies the Performance: prefix to align with Accessibility: and Security: item style. * fix(ci): resolve lint and test failures blocking CI - Fix skills/design-md-agent/pdfs/js/package.json: add @lightspeedwp scope and required fields (description, license, author, repository) - Fix .schemas/README.md: resolve git merge conflict markers - Fix scripts/agents/__tests__/reviewer.agent.test.js: avoid require() on module that uses import.meta.url; check file existence instead * fix: add trailing newline to 02-bug.md (MD047) * feat: add project assignment functionality to planner agent - Implement deriveProjectFromLabels() to map area labels to projects - Add project assignment recommendation to generated plans - Include confidence level and reasoning for assignments - Add logging for project assignment tracking - Support fallback to manual review for ambiguous cases This implements Phase 2 of the planner agent enhancement, enabling automatic project assignment based on issue labels. * fix: correct string replacement regex for project assignment section The regex now properly matches the footer including the HTML comment and uses regex instead of literal string to handle special characters. This fixes the project assignment section not being added to plans. * fix: add defensive checks and CRLF-aware regex - Add defensive check to ensure labels parameter is an array - Update regex to handle both LF and CRLF line endings (\r?\n) - Improves robustness across different environments * fix: correct YAML syntax error in metrics-summary workflow The multi-line JavaScript template literal was causing YAML parser errors. Converted to single-line string concatenation with proper variable handling. --------- Co-authored-by: Claude <noreply@anthropic.com> Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
1 participant
Summary
create_issuewithissue_writeacross all agent and prompt filesupdate_issuewithissue_write(same tool,method: create|update)get_issuewithissue_readinmode-prd.agent.mdskills/design-md-agent/linear/SKILL.mdwas intentionally left unchanged — it references Linear's owncreate_issueMCP tool, not GitHub's.Files changed
agents/mode-prd.agent.md.github/prompts/create-github-issue-feature-from-specification.prompt.md.github/prompts/create-github-issues-feature-from-implementation-plan.prompt.md.github/prompts/create-github-issues-for-unmet-specification-requirements.prompt.mdTest plan
create_issueorupdate_issuereferences in GitHub-targeted agent/prompt filesskills/design-md-agent/linear/SKILL.mdis unchangedCloses #52
Generated by Claude Code