policy(changelog): tighten meta:no-changelog usage and guardrails#463
Conversation
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
Warning Review limit reached
More reviews will be available in 12 minutes and 58 seconds. Learn how PR review limits work. Your organization has run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (4)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
github-actions
Bot
added
area:ci
🔍 Reviewer Summary for PR #463CI Status: ✅ Recommendations
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 75fe51102b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if echo "${PR_LABELS}" | grep -q '"meta:needs-changelog"' && echo "${PR_LABELS}" | grep -q '"meta:no-changelog"'; then | ||
| echo "::error::PR cannot include both meta:needs-changelog and meta:no-changelog." | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
This new failure path blocks the normal internal-only PR flow after automation has run: the labeling workflow triggers on PR open/labeled and scripts/agents/labeling.agent.js auto-adds meta:needs-changelog whenever a PR initially has no changelog label, but there is no corresponding cleanup when a maintainer later adds meta:no-changelog. In that common sequence the PR now has both labels and this workflow fails until someone manually removes the stale auto-added label, so the guardrail should either remove/ignore the stale label when meta:no-changelog is present or the labeling agent should enforce the mutual exclusion.
Useful? React with 👍 / 👎.
…bel-policy-hardening
ashleyshaw
added
meta:no-changelog
🔍 Reviewer Summary for PR #463CI Status: ✅ Recommendations
|
1 participant
Summary
Tightens changelog labelling policy to stop overuse of
meta:no-changelogand prevent contradictory labels on PRs.What changed
.github/workflows/changelog-validate.yml:meta:needs-changelogandmeta:no-changelogare present.meta:no-changelogis used ontype:feature,type:bug,type:performance,type:security,type:release, ortype:hotfixPRs..github/pull_request_template.mddocs/PR_LABELS.mddocs/AUTOMATION_GOVERNANCE.mdAudit actions completed
Live audit run for recent PRs/issues with
meta:no-changelog:meta:no-changelog: nonemeta:no-changelog: nonemeta:no-changelogfrom merged PRs where changelog scope was warranted:Validation
npm run lint:md -- .github/pull_request_template.md docs/PR_LABELS.md docs/AUTOMATION_GOVERNANCE.mdnpx jest scripts/validation/__tests__/validate-workflows.test.js --runInBandnpm run test:js) passed during commit.